[fixed] MP 1.2 Beta SVN single channel epg does not show correct program detail informations (1 Viewer)

disaster123

MP Donator
  • Premium Supporter
  • May 14, 2008
    3,558
    434
    Home Country
    Germany Germany
    Hi,

    in the actual SVN you don't get the correct program detail information in the single channel EPG, when you're at the bottom (last entry show the informations from one before).

    To reproduce:
    - Go to TV EPG
    - Select a single Channel
    - go down in the single channel EPG and watch the detail information
    - when you're at the bottom you will still see details from the entry before

    As the logs don't show anything to EPG at all and this is very easy to reproduce - i've not attached some clean logs. If you still wanna have them please ask.

    Thanks!

    Stefan
     

    robyf

    Retired Team Member
  • Premium Supporter
  • June 20, 2005
    1,076
    278
    52
    Bolzano
    Home Country
    Italy Italy
    Re: MP 1.2 Beta SVN single channel epg does not show correct program detail informati

    I can confirm this. When you scroll to the first no visible program, the program info is not updated (remains the one of the previous selected program).
     

    disaster123

    MP Donator
  • Premium Supporter
  • May 14, 2008
    3,558
    434
    Home Country
    Germany Germany
    AW: MP 1.2 Beta SVN single channel epg does not show correct program detail informati

    would be nice if this could be fixed before 1.2 beta will be released
     

    disaster123

    MP Donator
  • Premium Supporter
  • May 14, 2008
    3,558
    434
    Home Country
    Germany Germany
    AW: MP 1.2 Beta SVN single channel epg does not show correct program detail informati

    robyf
    can you bring this attention to this to the devs? Would be really bad if MP 1.2 beta is released with a bug like this.
     

    robyf

    Retired Team Member
  • Premium Supporter
  • June 20, 2005
    1,076
    278
    52
    Bolzano
    Home Country
    Italy Italy
    Re: MP 1.2 Beta SVN single channel epg does not show correct program detail informati

    Will open a mantis issue
     

    elliottmc

    Retired Team Member
  • Premium Supporter
  • August 7, 2005
    14,927
    6,061
    Cardiff, UK
    Home Country
    United Kingdom United Kingdom
    Re: MP 1.2 Beta SVN single channel epg does not show correct program detail informati

    Hi,

    Could you please post screenshots? I am unable to reproduce this problem, so it is clearly not universal (so the reproducibility of 'always' in mantis is not correct). Perhaps I am not testing correctly.

    Edit: Sorry, it is the program details, not program title. I can reproduce the problem now. As you continue scrolling, it always stays one program behind.

    Thanks,

    Mark
     

    pilehave

    Community Skin Designer
  • Premium Supporter
  • April 2, 2008
    2,566
    521
    Hornslet
    Home Country
    Denmark Denmark
    Re: MP 1.2 Beta SVN single channel epg does not show correct program detail informati

    Hi!

    This fix took me ~ 2 hours to find, but it is as simple as it is a needle, you know the saying with the needle and the haystack...:

    Code:
    Index: TvGuideBase.cs
    ===================================================================
    --- TvGuideBase.cs	(revision 27589)
    +++ TvGuideBase.cs	(working copy)
    @@ -2794,10 +2794,10 @@
             }
             if (updateScreen)
             {
    +          Update(false);
               SetFocus();
               UpdateCurrentProgram();
               SetProperties();
    -          Update(false);
             }
             return;
           }

    Patch attached!
     

    Attachments

    • scroll_update_fix_SVN27589.patch
      424 bytes

    SilentException

    Retired Team Member
  • Premium Supporter
  • October 27, 2008
    2,617
    1,130
    Rijeka, Croatia
    Home Country
    Croatia Croatia
    Re: MP 1.2 Beta SVN single channel epg does not show correct program detail informati

    Hehe, and on top of that TVGuide code is nightmare. Yesterday, I was researching this blindly (no debugging) and it was a total fiasco :) I saw that segment too :D

    Please remember, when doing changes in TV Guide, update Radio Guide too (they share 99% of the code that will be united in 1.3).
     

    elliottmc

    Retired Team Member
  • Premium Supporter
  • August 7, 2005
    14,927
    6,061
    Cardiff, UK
    Home Country
    United Kingdom United Kingdom
    Re: MP 1.2 Beta SVN single channel epg does not show correct program detail informati

    Hi,

    Fix tested, and confirmed to be working. Someone needs to commit this patch.

    Don't forget to do the same for radio EPG!

    Thanks,

    Mark
     

    Users who are viewing this thread

    Top Bottom