Reply to thread

Message

<blockquote data-quote="davidf" data-source="post: 656116" data-attributes="member: 19484">Hello Owlsroost,I've been having a few issues with the MP Audio Renderer and the showhelper together.&nbsp; I've been playing around with the code a bit and may have fixed it - I say may as it seems to be very easy to break it.&nbsp; I haven't made any significant changes to the code i.e. I don't think I should have fixed it, so i wanted to know is the code as easily broken as it seems or have I just fluked a fix.&nbsp; I'll leave&nbsp; it running for the evening and see what happens.&nbsp; There are a few bits of code which I am curious about as well if you don't mind I'll ask some questions on it.&nbsp; &nbsp; //De-sensitise frame dropping to avoid occasional delay glitches triggering frame drops&nbsp; &nbsp; if ((m_frameRateRatio &gt; 0) &amp;&amp; !m_bDVDMenu &amp;&amp; !m_bScrubbing)Why &gt;0 and not &gt;1? surely this will always apply unless paused or the framerate is way off.The only thing I have changed is the sleep time from 1.5ms to 1ms when it is close to scheduling time - and I doubt that has actaully fixed it as the issue seems to be due to latency and the extra execution cycles would increase the latency.I have noticed that appears to be a bug is that if a sample from the past is scheduled it is also dropped almost every time.Line 2526 and 2544 both should have i++ in the loop as well as the first sample is not currently checked (almost certain to make no difference).David</blockquote>

[QUOTE="davidf, post: 656116, member: 19484"] Hello Owlsroost, I've been having a few issues with the MP Audio Renderer and the showhelper together. I've been playing around with the code a bit and may have fixed it - I say may as it seems to be very easy to break it. I haven't made any significant changes to the code i.e. I don't think I should have fixed it, so i wanted to know is the code as easily broken as it seems or have I just fluked a fix. I'll leave it running for the evening and see what happens. There are a few bits of code which I am curious about as well if you don't mind I'll ask some questions on it. //De-sensitise frame dropping to avoid occasional delay glitches triggering frame drops if ((m_frameRateRatio > 0) && !m_bDVDMenu && !m_bScrubbing) Why >0 and not >1? surely this will always apply unless paused or the framerate is way off. The only thing I have changed is the sleep time from 1.5ms to 1ms when it is close to scheduling time - and I doubt that has actaully fixed it as the issue seems to be due to latency and the extra execution cycles would increase the latency. I have noticed that appears to be a bug is that if a sample from the past is scheduled it is also dropped almost every time. Line 2526 and 2544 both should have i++ in the loop as well as the first sample is not currently checked (almost certain to make no difference). David [/QUOTE]

Verification