Reply to thread

Message

<blockquote data-quote="yoavain" data-source="post: 1008219" data-attributes="member: 92067">I've checked the MP code, and it seems that the #Play.Current.Lyrics property is set in the GUIMusicOverlay (along with other properties).The tag is set here (in the same class):[spoiler][CODE]MusicTag tag;&nbsp;&nbsp; &nbsp; &nbsp; if (string.IsNullOrEmpty(filename))&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; return;&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; // last.fm radio sets properties manually therefore do not overwrite them.&nbsp; &nbsp; &nbsp; if (Util.Utils.IsLastFMStream(filename))&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; return;&nbsp; &nbsp; &nbsp; }&nbsp;&nbsp; &nbsp; &nbsp; // Radio Properties are set already in Play routine&nbsp; &nbsp; &nbsp; if (g_Player.IsRadio)&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; return;&nbsp; &nbsp; &nbsp; }&nbsp;&nbsp; &nbsp; &nbsp; // When Playing an Internet Stream, via BASS, skin properties are set during the Play method in BassAudio.cs&nbsp; &nbsp; &nbsp; if (BassMusicPlayer.IsDefaultMusicPlayer &amp;&amp; isInternetStream)&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; return;&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; else&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; tag = GetTag(filename);&nbsp; &nbsp; &nbsp; }[/CODE][/spoiler]&nbsp;However, in the BassAudio.cs, the lyrics property is not set, only the following:[spoiler][CODE]// and display what we get&nbsp; &nbsp; &nbsp; GUIPropertyManager.SetProperty(&quot;#Play.Current.Album&quot;, _tagInfo.album);&nbsp; &nbsp; &nbsp; GUIPropertyManager.SetProperty(&quot;#Play.Current.Artist&quot;, _tagInfo.artist);&nbsp; &nbsp; &nbsp; GUIPropertyManager.SetProperty(&quot;#Play.Current.Title&quot;, title);&nbsp; &nbsp; &nbsp; GUIPropertyManager.SetProperty(&quot;#Play.Current.Comment&quot;, _tagInfo.comment);&nbsp; &nbsp; &nbsp; GUIPropertyManager.SetProperty(&quot;#Play.Current.Genre&quot;, _tagInfo.genre);&nbsp; &nbsp; &nbsp; GUIPropertyManager.SetProperty(&quot;#Play.Current.Year&quot;, _tagInfo.year);[/CODE][/spoiler]&nbsp;Lyrics are either forgotten or not parsed at all...&nbsp;Either way, I'm not sure if that related to MyLyrics. I could set this property, when finding the lyrics.The issue is with MP not parsing lyrics from file's metadata...</blockquote>

[QUOTE="yoavain, post: 1008219, member: 92067"] I've checked the MP code, and it seems that the #Play.Current.Lyrics property is set in the GUIMusicOverlay (along with other properties). The tag is set here (in the same class): [spoiler][CODE]MusicTag tag; if (string.IsNullOrEmpty(filename)) { return; } // last.fm radio sets properties manually therefore do not overwrite them. if (Util.Utils.IsLastFMStream(filename)) { return; } // Radio Properties are set already in Play routine if (g_Player.IsRadio) { return; } // When Playing an Internet Stream, via BASS, skin properties are set during the Play method in BassAudio.cs if (BassMusicPlayer.IsDefaultMusicPlayer && isInternetStream) { return; } else { tag = GetTag(filename); }[/CODE][/spoiler] However, in the BassAudio.cs, the lyrics property is not set, only the following: [spoiler][CODE]// and display what we get GUIPropertyManager.SetProperty("#Play.Current.Album", _tagInfo.album); GUIPropertyManager.SetProperty("#Play.Current.Artist", _tagInfo.artist); GUIPropertyManager.SetProperty("#Play.Current.Title", title); GUIPropertyManager.SetProperty("#Play.Current.Comment", _tagInfo.comment); GUIPropertyManager.SetProperty("#Play.Current.Genre", _tagInfo.genre); GUIPropertyManager.SetProperty("#Play.Current.Year", _tagInfo.year);[/CODE][/spoiler] Lyrics are either forgotten or not parsed at all... Either way, I'm not sure if that related to MyLyrics. I could set this property, when finding the lyrics. The issue is with MP not parsing lyrics from file's metadata... [/QUOTE]

Verification