Reply to thread

Message

<blockquote data-quote="mackey" data-source="post: 123274" data-attributes="member: 20257">Thanks tomtom21000 and Taipan for your testing and feedback. It is really appreciated, and a great help in fixing the small bugs that undoubtfully still is present in the current release.tomtom21000i) The lyricsengine have a quite complex structure with up to 30 searching running in their own thread. Each thread reports its outcome (if a lyric was found or not at a specific site) back to a controller class when it has finished. I thought all the issues of threads not ending and not giving a proper message to the controller class were all sorted out, but it seems like their still is a issues or two.I'm currently making some refactoring of the different types of lyrics searches and will as a bonus obtain a clearer and better handling of threads. It will help me to find the problem, or perhaps the problem will be fixed in the refactoring-work itself. I will make another test when the refactoring is completed and fix any errors that I find.ii) I save the lyrics in Lyrics.xml that is located in the MP directory.iii) I cannot quite see the point in saving the lyrics from music tags in the database. At least now when there are no export of the xml or no other plugin is using it. However it might in the future and then it would be a good idea. But I'll put in on my todo-list.iv) The wish for a directory-based .txt-add is also put on the todo-list. I see that the search for matching .txt-files in a direcory and subdirectories will be very handy when added a lot of files. The features will natural also be relevant for lrc-files.</blockquote>

[QUOTE="mackey, post: 123274, member: 20257"] Thanks tomtom21000 and Taipan for your testing and feedback. It is really appreciated, and a great help in fixing the small bugs that undoubtfully still is present in the current release. [u]tomtom21000[/u] i) The lyricsengine have a quite complex structure with up to 30 searching running in their own thread. Each thread reports its outcome (if a lyric was found or not at a specific site) back to a controller class when it has finished. I thought all the issues of threads not ending and not giving a proper message to the controller class were all sorted out, but it seems like their still is a issues or two. I'm currently making some refactoring of the different types of lyrics searches and will as a bonus obtain a clearer and better handling of threads. It will help me to find the problem, or perhaps the problem will be fixed in the refactoring-work itself. I will make another test when the refactoring is completed and fix any errors that I find. ii) I save the lyrics in Lyrics.xml that is located in the MP directory. iii) I cannot quite see the point in saving the lyrics from music tags in the database. At least now when there are no export of the xml or no other plugin is using it. However it might in the future and then it would be a good idea. But I'll put in on my todo-list. iv) The wish for a directory-based .txt-add is also put on the todo-list. I see that the search for matching .txt-files in a direcory and subdirectories will be very handy when added a lot of files. The features will natural also be relevant for lrc-files. [/QUOTE]

Verification