Reply to thread

Message

<blockquote data-quote="Anonymous" data-source="post: 12080">hi,first of a all great work !!!At first look your code seems to be quite clear - you could perhaps have a look here, how naming conventions etc. are in MP<a href="http://nolanparty.com/mediaportal.sourceforge.net/phpBB2/viewtopic.php?t=2631" target="_blank">http://nolanparty.com/mediaportal.sourceforge.net/phpBB2/viewtopic.php?t=2631</a>some remarks:&nbsp;- it would be nice if your plugins would be called DevicePlugins or sth. like this so that you can't be confused with &quot;normal&quot; plugins- I think version management for DevicePlugins would be useful if something is changed in your InputDeviceMapper- I think it would be better if the mapping would be linked with a control so that you choose DevicePlugin first and then the mapping - not you can see all mappings all the time - perhaps you could first choose Plugin then show setup dialog with a tabControl where at 1st tab general setup-form, 2nd tab&nbsp; mapping stuff, (perhaps 3rd tab control testing area)- at the moment if you add a new mapping it is really bothering to enter a name, perhaps you could add default name or name=action or something else?!- I think it would be easier if you want to add a lot of mappings that all available commands are listed in a listview and you could select the action you want to learn (perhaps you could have a look on my (old) WinLirc AddOn I posted a few days ago in patch section - I did somthing like that)- small bug: if you have no plugin selected and then click configure plugins -&gt; configure&nbsp; you get an exceptionbut don't get me wrong this should not be criticism - just a few ideas to improve this great project ;-)P.S.:As promised I coded the NewWinLirc as a plugin using your InputDeviceMapper 2.0. You can find it here:<a href="https://sourceforge.net/tracker/index.php?func=detail&amp;aid=1160983&amp;group_id=107397&amp;atid=647927" target="_blank">https://sourceforge.net/tracker/index.php?func=detail&amp;aid=1160983&amp;group_id=107397&amp;atid=647927</a>keans</blockquote>

[QUOTE="Anonymous, post: 12080"] hi, first of a all great work !!! At first look your code seems to be quite clear - you could perhaps have a look here, how naming conventions etc. are in MP [url]http://nolanparty.com/mediaportal.sourceforge.net/phpBB2/viewtopic.php?t=2631[/url] some remarks: - it would be nice if your plugins would be called DevicePlugins or sth. like this so that you can't be confused with "normal" plugins - I think version management for DevicePlugins would be useful if something is changed in your InputDeviceMapper - I think it would be better if the mapping would be linked with a control so that you choose DevicePlugin first and then the mapping - not you can see all mappings all the time - perhaps you could first choose Plugin then show setup dialog with a tabControl where at 1st tab general setup-form, 2nd tab mapping stuff, (perhaps 3rd tab control testing area) - at the moment if you add a new mapping it is really bothering to enter a name, perhaps you could add default name or name=action or something else?! - I think it would be easier if you want to add a lot of mappings that all available commands are listed in a listview and you could select the action you want to learn (perhaps you could have a look on my (old) WinLirc AddOn I posted a few days ago in patch section - I did somthing like that) - small bug: if you have no plugin selected and then click configure plugins -> configure you get an exception but don't get me wrong this should not be criticism - just a few ideas to improve this great project ;-) P.S.: As promised I coded the NewWinLirc as a plugin using your InputDeviceMapper 2.0. You can find it here: [url]https://sourceforge.net/tracker/index.php?func=detail&aid=1160983&group_id=107397&atid=647927[/url] keans [/QUOTE]

Verification