[Approved] No teletext subs until stop/restart subs (1 Viewer)

[jblomb]

I have noticed that i need to stop/restart the teletext subs on TV, or at least change from fullscreen TV to TV Home and back to show the subtitles.
This is not necessary the first time, but whenever I change channel etc I need to do it.

Looking through the logs I found:

Subtitle: Creating vertex buffer
Subtitle: Setting vertices

...but after changing channel the line Setting vertices doesn't show up.
To save processing power etc the renderer doesn't set up vertices unless render resolution change, but it needs to set them up every time the vertex buffer is created as well.

This patch resets the saved render resolution when the vertex buffer is created ,so the vertices are set as well.

Index: Core/Player/Subtitles/SubtitleRenderer.cs
===================================================================
--- Core/Player/Subtitles/SubtitleRenderer.cs	(revision 25394)
+++ Core/Player/Subtitles/SubtitleRenderer.cs	(working copy)
@@ -863,6 +863,7 @@
                                         4, GUIGraphicsContext.DX9Device,
                                         0, CustomVertex.TransformedTextured.Format,
                                         GUIGraphicsContext.GetTexturePoolType());
+        wx0 = wy0 = wwidth0 = wheight0 = 0;
       }
 
       if (wx0 != wx || wy0 != wy || wwidth0 != wwidth || wheight0 != wheight)

Regards
Blomman

 

[tourettes]

Isn't that fixing the issue? 0002788: teletext subtitles only working the first time. - MediaPortal Bugtracker

 

[jblomb]

It looks like.
I am always trying to figure out my own hickups, so I'm not keeping track of the issues in the bugtracker.

..but then again
My own problem was not fixed in the current SVN, so I don't know.
This might be another issue.

 

[tourettes]

It looks like.
I am always trying to figure out my own hickups, so I'm not keeping track of the issues in the bugtracker.

Could you verify that it solves the issue? I'll close this thread if the issue is already solved.

 

[jblomb]

I'll check, but I think this is another issue.

No, this is another issue. It has nothing to do with "fixed ; subFilter not released all the time."
This issue occurs when it "remembers" the values for vertex buffer.

        // remember what the vertexBuffer is set to
        wy0 = wy;
        wx0 = wx;
        wheight0 = wheight;
        wwidth0 = wwidth;

and then after changing channel the vertex buffer is created, but:

      if (wx0 != wx || wy0 != wy || wwidth0 != wwidth || wheight0 != wheight)

That code prevents the vertex buffer to be set up properly.
Hence my patch which sets wx0, wy0, wwidth0 and wheight0 to 0 immediately after creating the vertex buffer to ensure that the vertex buffer is set up properly every time it's been created.

 

[tourettes]

0002804: Teletext subtitles aren't always visible - MediaPortal Bugtracker

 

[jblomb]