Now Playing in 0.2.2.0 has incorrect "next" (1 Viewer)

[Doodles]

[MediaPortal Version: 0.2.2.0
MediaPortal Skin: BlueTwo wide
Windows Version: Windows XP (SP2)
.NET CLR Version: 2.0.50727
DirectX Version: 4.09.00.0904 (9.0c)
CPU Type: AMD Sempron 3100+ 1.81GHz
HDD: ?? 200Gb
Memory: 1Gb DDM
Motherboard: Gigabyte GA-K8VM800M
Motherboard Chipset: VIA K8M800
Video Card Model: Nvidia Geforce 6200 (128 MB)
Video Card Resolution: 1440x900
[Sound Card: (on board) Realtek AC'97
Sound Card Driver: 5.10.0.5930
1. TV Card: LeadTek WinFast DTV1000 T
1. TV Card Type: DVB-T
Audio Codec: MPA Decoder Filter
Video Codec: MPV Decoder Filter
[Remote: MCE
TV: Acer AL1916 19" widescreen monito
TV - HTPC Connection: Sub-D

When using MP 0.2.2.0, start a track playing and switch to the Now Playing Screen. The "Next" track shown is correct. However, as soon as the current track finishes, or if you skip to the next track, the "Next" track displayed is the same as the current track.

Let me know if you need a log.

 

[chenks]

confirmed...i have this also

 

[DalaNorth]

Confirmed as a bug. In GUIMusicOverlay.cs, the GetInfo method takes a filename as parameter, however, if id3 tags are not enabled in MediaPortal.xml, this method defaults to taking the tag from the current playing track in the playlist. So, as a workaround, enable id3 tags in MediaPortal.xml. The bug still needs fixing though!

(To enable id3 tags, open MediaPortal.xml in your favorite text editor and change <entry name="showid3">no</entry> to <entry name="showid3">yes</entry> under <section name="musicfiles">)

Regards
DalaNorth

 

[chefkoch]

I had the same issue some days ago, too.

But with latest svn-revision (12495) it is working like a charm here. So i can not confirm anymore.

for testing and reporting.

regards
chefkoch

 

[DalaNorth]

Still can't get it to work

I don't mean to offend you, but are you sure? I just did an SVN update (to 12497) and I still have the problem unless "Load ID3 tags from file if it's not in music database (slow)" is checked. Just look at the code, this method is called with the next track's filename:

MusicTag GetInfo(string fileName, out string thumb)
    {
      string skin = GUIGraphicsContext.Skin;
      thumb = String.Empty;
      MusicTag tag = null;

      if (_useID3)
      {
        //yes, then try reading the tag from the file
        tag = TagReader.TagReader.ReadTag(fileName);
      }

      // if we're playing a radio
      if (Recorder.IsRadio())
      {
---------------------------8<------------------------- cut
      }
      if (g_Player.IsRadio)
      {
---------------------------8<------------------------- cut
      } //if (g_Player.IsRadio)


      // check playlist for information
      if (tag == null)
      {
        PlayListItem item = playlistPlayer.GetCurrentItem();
        if (item != null)
          tag = (MusicTag)item.MusicTag;
      }

If we don't have _useID3, it will grab the tag from the current item in the playlist...

I don't know, maybe I'm doing something wrong, but it still doesn't work for me...

:sorry:

 

[chefkoch]

ehh DalaNorth what's wrong? no sorry

LOL I am so sorry that i did not read you last post correct.

How could it be that the option was enabled here?

With the option "Load ID3 tags from file if it's not in music database (slow)" disabled it is buggy, when enabling this all works fine.

So it is CONFIRMED and sorry again for confusing you

regards
chefkoch

 

[rtv]

fixed in Rev 12500

 

[DalaNorth]

Nice work!

Hey, thanks! That did the trick. I was actually minutes away from posting a patch on SourceForge, but you had almost exactly the same solution as I did so again!

Regards
DalaNorth

 

[reagan+carter]

great! another capable user who can fix bug and help out rtv already swamped with work.

thanks both of you

 

[chefkoch]

fixed here, too.

regards
chefkoch