OnDeviceChange crashing in 64-bit version (1 Viewer)

[Anthony Vaughan]

Now that MediaPortal has gone 64-bit, any references to lParam should be converted to int64 rather than int32 or compared to zero without being converted.

An example of this is the OnDeviceChange method in MediaPortal.cs where the following fails:

if (msg.LParam.ToInt32() != 0)
{

The fix is to change this to:

if (msg.LParam.ToInt64() != 0)
{

or

if (msg.LParam != IntPtr.Zero)
{

There may be other places where this is happening but this example cropped up when I introduced a DVD player to my setup.

Hope this helps.

 

[doskabouter]

hm, I might have missed those in my attempt to iron out all the x64 issues...
Will try to find all of them

 

[doskabouter]

Huh I already changed that.
You need to have the latest mediaportal installer to fix that

 

[Anthony Vaughan]

Yes. It's not easy to spot them all.

I expect many MP1 users don't switch to other so this wouldn't happen to them.

I only came across this because I added DVD player to my setup and started to get log errors when switching between the MP1 laptop and the DVD player.

 

[doskabouter]

yea ok but which version of mediaportal do you run? the one with 2025-05-03 in it has that fix in it

 

[Anthony Vaughan]

Ah. The timestamp on MediaPortal.cs is 23/04/2025 03:58.

I've looked at the GIT Hub and see that you have fixed it.

Sorry to have bothered you.

 

[Anthony Vaughan]

I have been using the following link to access the MP1 GIT HUB:

GitHub - MediaPortal/MediaPortal-1: Home Theater and Digital Video Recording solution for Windows.

Home Theater and Digital Video Recording solution for Windows. - MediaPortal/MediaPortal-1

github.com

This page doesn't reflect changes to sources after the final release is enacted. For example, it says the last change is 2 months ago.

Is there a way to know that sources have been changed since a new release so I don't bother you unnecessarily?

 

[doskabouter]

Those folder's last modified time isn't really accurate it seems. Latest change was a merge from PR #384 on may 3rd which was exactly that fix, see f.e. MediaPortal-1/mediaportal/MediaPortal.Application/MediaPortal.cs at 8fa4ccca20059a5534a029266efa596e83387f5b · MediaPortal/MediaPortal-1