OnlineVideos 2.4.0.0 [2024/02/24] (9 Viewers)

offbyone

Development Group
  • Team MediaPortal
  • April 26, 2008
    3,989
    3,712
    Stuttgart
    Home Country
    Germany Germany
    Thanks good info! Is there a branch or changeset I can merge to Onlinevideos for MP 1.16 compatibility?
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    Here we go :)
    It's a global patch where i get some issues :

    So :
    1- Upgrade Bump version for madVR
    2- Remove illegal character when download video and change handle for madVR (not a really good patch but solve downloading trailer with wrong char)
    3- MadVR and build (Change the code to have OV working with EVR and madVR)

    Thanks :)
     

    Attachments

    • 0001-WIP-OV-Sebastiii-Upgrade-Bump-version-for-madVR.patch
      14.8 KB

    doskabouter

    Development Group
  • Team MediaPortal
  • September 27, 2009
    4,566
    2,938
    Nuenen
    Home Country
    Netherlands Netherlands
    Couple of remarks for your patch:
    - Instead of manually fixing the titles, there is a FileUtils.GetSaveFilename which does the job
    - The xmp2 changes are not needed
    The rest seems ok (unable to test, so I'll take your word for it to work :) )
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    Couple of remarks for your patch:
    - Instead of manually fixing the titles, there is a FileUtils.GetSaveFilename which does the job
    - The xmp2 changes are not needed
    The rest seems ok (unable to test, so I'll take your word for it to work :) )

    I remember has trying the method but maybe i did it wrongly because it wasn't working, so i will retry :)
    About the xmp2, you are right, it's only for me OV source are on different hdd. (maybe we can change it to "%ProgramFiles(x86)%" instead ?
    Thanks :)
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    Couple of remarks for your patch:
    - Instead of manually fixing the titles, there is a FileUtils.GetSaveFilename which does the job
    - The xmp2 changes are not needed
    The rest seems ok (unable to test, so I'll take your word for it to work :) )

    I just retry with your method and it works :)
    Thanks.

    Reverted previous code and just added line 4 and 5 (so to remove illegal char like " : "

    C#:
                if (string.IsNullOrEmpty(saveItems.CurrentItem.Title)) saveItems.CurrentItem.Title = saveItems.CurrentItem.VideoInfo.Title;
    
                // Replace illegal char
                saveItems.CurrentItem.VideoInfo.Title = FileUtils.GetSaveFilename(saveItems.CurrentItem.Title);
    
                if (!string.IsNullOrEmpty(saveItems.CurrentItem.OverrideFolder))
     

    offbyone

    Development Group
  • Team MediaPortal
  • April 26, 2008
    3,989
    3,712
    Stuttgart
    Home Country
    Germany Germany
    Committed and Pushed, thx Sebastiii!

    @morpheus_xx : You can now merge your changes that are required to work with the upcoming MP2 release. I have already increased the API version of OnlineVideos to 2.3.

    Let's get a working OV version out for the new MP1 and MP2 releases before x-mas ;)
     

    Users who are viewing this thread

    Top Bottom