Reply to thread

Message

i know that it won't come into trunk in at least 2 weeks, but still..
reworked version of the patch with optimizations for almost every channel list in TVSetup:
Tv/Radio complete channel lists and channel list groups
Tv/Radio channel mapping lists
Tv/Radio channel combining lists
Tv/Radio EPG channel lists
Combobox with all channels in Manual control
Optimization (in my case getting e.g. "All channels" TV group content for 4k5 channels takes now less than 4 seconds instead of 80 in unpatched SetupTV) is done via rewriting of SQL queries and using dictionaries for searching in lists. Another part is the optimized filling of ListViews.
Almost all this stuff i implemented as several functions and placed them in new file ChannelListHelper.cs

Other changes:
added enumeration ChannelProviderType instead of direct numbers (i hate magic numbers in code)
added function to retrieve icon index for a channel from its tuningdetails (again, i hate magic numbers)
consolidated radio and tv code (this part contains most of spaces/linefeeds changes in the patch) for easier maintaining of it later
added "use for EPG only" to radio EPG channel list (similar to TV list, also see above)
added indication of DVB-S2 channels

I hope that devs also take a critical look to my coding style, and if it doesn't fit to MP - then let me know

<blockquote data-quote="Vasilich" data-source="post: 785629" data-attributes="member: 97516">i know that it won't come into trunk in at least 2 weeks, but still..reworked version of the patch with optimizations for almost every channel list in TVSetup: <ul>
<li data-xf-list-type="ul">Tv/Radio complete channel lists and channel list groups</li>
<li data-xf-list-type="ul">Tv/Radio channel mapping lists</li>
<li data-xf-list-type="ul">Tv/Radio channel combining lists</li>
<li data-xf-list-type="ul">Tv/Radio EPG channel lists</li>
<li data-xf-list-type="ul">Combobox with all channels in Manual control</li>
</ul>Optimization (in my case getting e.g.&nbsp; &quot;All channels&quot; TV group content for 4k5 channels takes now less than 4 seconds instead of 80 in unpatched SetupTV) is done via rewriting of SQL queries and using dictionaries for searching in lists. Another part is the optimized filling of ListViews.Almost all this stuff i implemented as several functions and placed them in new file ChannelListHelper.csOther changes:<ul>
<li data-xf-list-type="ul">added enumeration ChannelProviderType instead of direct numbers (i hate magic numbers in code)</li>
<li data-xf-list-type="ul">added function to retrieve icon index for a channel from its tuningdetails (again, i hate magic numbers)</li>
<li data-xf-list-type="ul">consolidated radio and tv code (this part contains most of spaces/linefeeds changes&nbsp; in the patch) for easier maintaining of it later</li>
<li data-xf-list-type="ul">added &quot;use for EPG only&quot; to radio EPG channel list (similar to TV list, also see above)</li>
<li data-xf-list-type="ul">added indication of DVB-S2 channels</li>
</ul>I hope that devs also take a critical look to my coding style, and if it doesn't fit to MP - then let me know <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite2" alt=";)" title="Wink&nbsp; &nbsp; ;)" loading="lazy" data-shortname=";)" /></blockquote>

[QUOTE="Vasilich, post: 785629, member: 97516"] i know that it won't come into trunk in at least 2 weeks, but still.. reworked version of the patch with optimizations for almost every channel list in TVSetup: [LIST] [*]Tv/Radio complete channel lists and channel list groups [*]Tv/Radio channel mapping lists [*]Tv/Radio channel combining lists [*]Tv/Radio EPG channel lists [*]Combobox with all channels in Manual control [/LIST] Optimization (in my case getting e.g. "All channels" TV group content for 4k5 channels takes now less than 4 seconds instead of 80 in unpatched SetupTV) is done via rewriting of SQL queries and using dictionaries for searching in lists. Another part is the optimized filling of ListViews. Almost all this stuff i implemented as several functions and placed them in new file ChannelListHelper.cs Other changes: [LIST] [*]added enumeration ChannelProviderType instead of direct numbers (i hate magic numbers in code) [*]added function to retrieve icon index for a channel from its tuningdetails (again, i hate magic numbers) [*]consolidated radio and tv code (this part contains most of spaces/linefeeds changes in the patch) for easier maintaining of it later [*]added "use for EPG only" to radio EPG channel list (similar to TV list, also see above) [*]added indication of DVB-S2 channels [/LIST] I hope that devs also take a critical look to my coding style, and if it doesn't fit to MP - then let me know ;) [/QUOTE]