[Approved] Optimized property manager (1 Viewer)

[armandp]

In my quest for speed/resource improvements in mediaportal i came across the property manager and discovered that it literally iterated through every property when it parses input (control labels etc.. ) combined with some unfortunate locking. On slower systems this is causing some problems, and on faster systems this could become a problem when lots of properties are being updated.

The best solution would be to reinvent the property tags but i leave that to MPII so i made a compatible solution that does not require any changes to existing code and skins. This patch optimizes the process by replacing only the required labels opposed to iterating through ALL labels everytime something needs to be parsed. I also eased the locking part. Ofcourse this means this patch will touch everything in mediaportal and could be considered high risk but from the first tests done by me and several users i can report positieve feedback in terms of a global speedup of mediaportal.

I already have another topic where i posted a patched core.dll (based on RC1) with this and my other patch implemented.

Please review the patch carefully. If no serious bugs are discovered i would like to have this implemented rather sooner than later as it can make a huge difference.

 

[SilentException]

confirmed this also fixes slowness in games:
https://forum.team-mediaportal.com/588805-post10.html

great work!

 

[chemelli]

Commited to svn25210

again Armand!

Simone

 

[Inker]

Great initiative.

Small nitpick, several times in your patch you do a (if dict.containskey(key) [...] val = dict[key]). While dict access is O(1) it would still be faster to use dict.TryGetValue instead to save that one extra lookup. More importantly though, from what I can see, this gets rid of at least 2 locks since they are no longer needed.

Just saying if youre hunting for speed. Let me know if it helped any.

 

[armandp]

yeah gibman also responsed with the same tip in my other patch i will update both patches with TryGetValue as we can use every speed increase we can SO chemelli expect another update to this patch (or probably a patch to the committed revision). I'm currently on holiday (only checking mail and forum lol) when i get back on friday i will update both patches

 

[gibman]

arman, Ive already committed those changes.
Please review

Also removed dead code, comments, and fixed tabs and brackets {} to match our coding convetion.

and thanks again.

/gibman