Reply to thread

Message

<blockquote data-quote="mm1352000" data-source="post: 1184891" data-attributes="member: 82144">The plugin detects skipping based on this condition:<a href="https://github.com/kwill1429/pandora-musicbox/blob/master/Source/MediaPortalPlugin/GUI/MusicBoxGUI.cs#L172" target="_blank">https://github.com/kwill1429/pandora-musicbox/blob/master/Source/MediaPortalPlugin/GUI/MusicBoxGUI.cs#L172</a>[code]bool isSkip = PlayingRadio &amp;&amp; !ignoreSkip;[/code]ignoreSkip has and is always going to be false in this case, so the change in behaviour seems most likely to be as a result of a change in the &quot;PlayingRadio&quot; part of the condition. The code for that property is:<a href="https://github.com/kwill1429/pandora-musicbox/blob/master/Source/MediaPortalPlugin/GUI/MusicBoxGUI.cs#L23" target="_blank">https://github.com/kwill1429/pandora-musicbox/blob/master/Source/MediaPortalPlugin/GUI/MusicBoxGUI.cs#L23</a>[code]private bool PlayingRadio { get { return g_Player.Playing &amp;&amp; Core.MusicBox.CurrentSong != null &amp;&amp; g_Player.CurrentFile == Core.MusicBox.CurrentSong.AudioURL; } }[/code]I would guess that the issue is that g_Player.Playing is still true and/or g_Player.CurrentFile is not set null before OnPlaybackEnded() is invoked... and it may not have been that way in the past.</blockquote>

[QUOTE="mm1352000, post: 1184891, member: 82144"] The plugin detects skipping based on this condition: [URL]https://github.com/kwill1429/pandora-musicbox/blob/master/Source/MediaPortalPlugin/GUI/MusicBoxGUI.cs#L172[/URL] [code]bool isSkip = PlayingRadio && !ignoreSkip;[/code] ignoreSkip has and is always going to be false in this case, so the change in behaviour seems most likely to be as a result of a change in the "PlayingRadio" part of the condition. The code for that property is: [URL]https://github.com/kwill1429/pandora-musicbox/blob/master/Source/MediaPortalPlugin/GUI/MusicBoxGUI.cs#L23[/URL] [code] private bool PlayingRadio { get { return g_Player.Playing && Core.MusicBox.CurrentSong != null && g_Player.CurrentFile == Core.MusicBox.CurrentSong.AudioURL; } } [/code] I would guess that the issue is that g_Player.Playing is still true and/or g_Player.CurrentFile is not set null before OnPlaybackEnded() is invoked... and it may not have been that way in the past. [/QUOTE]

Verification