Reply to thread

Message

<blockquote data-quote="CyberSimian" data-source="post: 1246873" data-attributes="member: 141969">I think that this proposed change is a worthwhile enhancement, and I would probably use it myself.&nbsp; However, I am not so happy with the proposed implementation.Suggested designIn my view we should offer this enhancement in a manner that is as consistent as possible with the existing support.&nbsp; We currently have a setting in &quot;MP Config&quot; that allows the user to specify the threshhold that separates unwatched recordings and videos from watched recordings and videos.&nbsp; The consistent approach is to add another setting to &quot;MP Config&quot; to separate unwatched from partly-watched.&nbsp; So &quot;MP Config&quot; might have something like this:Played time percentage needed to mark the video as partly watched (0-100%)Played time percentage needed to mark the video as fully watched (0-100%)In the skin, we introduce the new tag suggested by [USER=68833]@ajs[/USER] , namely &lt;playingColor&gt;, but without any attributes (no &quot;min&quot; or &quot;max&quot;). Then the logic that the skin engine would use for selecting the colour would be:[code]if (played_percent &gt;= fully_watched_threshhold)&nbsp; color = &lt;playedColor&gt;;else if (played_percent &gt;= partly_watched_threshhold)&nbsp; color = &lt;playingColor&gt;;else&nbsp; color = &lt;textcolor&gt;;[/code]Note that if partly_watched_threshhold &gt;= fully_watched_threshhold, &lt;playingColor&gt; is never used.CompatibilityIn previous releases, if the played percent was less than the fully-watched threshhold, the item was displayed with &lt;textcolor&gt;. Skins which are moribund (or not updated with this change) will lack the &lt;playingColor&gt; tag, so defaults need to be such that there is no change in the appearance of those skins.No change in the appearance of moribund skins can be achieved by setting partly-watched threshhold equal to fully-watched threshhold in &quot;MediaPortal.xml&quot; when the user installs the new version of MP (this should be done automatically as part of the install process).In the window xml file, a control can omit tags where the default value is wanted. If a tag is omitted, the value is taken from the value specified by the default style in &quot;references.xml&quot;.&nbsp; If the tag is also omitted from the style in &quot;references.xml&quot;, the value specified by the hard-coded built-in defaults in the skin engine is used. A suitable hard-coded default needs to be chosen for &lt;playingColor&gt; for the skin engine. This should probably follow the existing convention used for the other numerous &lt;xxxColor&gt; tags.Where do we go from hereIf the modified DLL that [USER=68833]@ajs[/USER] has provided to the original poster works as intended, there is no reason why the original poster shouldn't continue using it until the next release (MP 1.21).&nbsp; However, I think that the implementation should be reworked as outlined above, before being made available in an MP build.-- from CyberSimian in the UK</blockquote>

[QUOTE="CyberSimian, post: 1246873, member: 141969"] I think that this proposed change is a worthwhile enhancement, and I would probably use it myself. However, I am not so happy with the proposed implementation. [b]Suggested design[/b] In my view we should offer this enhancement in a manner that is as consistent as possible with the existing support. We currently have a setting in "MP Config" that allows the user to specify the threshhold that separates unwatched recordings and videos from watched recordings and videos. The consistent approach is to add another setting to "MP Config" to separate unwatched from partly-watched. So "MP Config" might have something like this: [I]Played time percentage needed to mark the video as partly watched (0-100%) Played time percentage needed to mark the video as fully watched (0-100%)[/I] In the skin, we introduce the new tag suggested by [USER=68833]@ajs[/USER] , namely <playingColor>, but without any attributes (no "min" or "max"). Then the logic that the skin engine would use for selecting the colour would be: [code]if (played_percent >= fully_watched_threshhold) color = <playedColor>; else if (played_percent >= partly_watched_threshhold) color = <playingColor>; else color = <textcolor>;[/code] Note that if partly_watched_threshhold >= fully_watched_threshhold, <playingColor> is never used. [b]Compatibility[/b] In previous releases, if the played percent was less than the fully-watched threshhold, the item was displayed with <textcolor>. Skins which are moribund (or not updated with this change) will lack the <playingColor> tag, so defaults need to be such that there is no change in the appearance of those skins. No change in the appearance of moribund skins can be achieved by setting partly-watched threshhold equal to fully-watched threshhold in "MediaPortal.xml" when the user installs the new version of MP (this should be done automatically as part of the install process). In the window xml file, a control can omit tags where the default value is wanted. If a tag is omitted, the value is taken from the value specified by the default style in "references.xml". If the tag is also omitted from the style in "references.xml", the value specified by the hard-coded built-in defaults in the skin engine is used. A suitable hard-coded default needs to be chosen for <playingColor> for the skin engine. This should probably follow the existing convention used for the other numerous <xxxColor> tags. [b]Where do we go from here[/b] If the modified DLL that [USER=68833]@ajs[/USER] has provided to the original poster works as intended, there is no reason why the original poster shouldn't continue using it until the next release (MP 1.21). However, I think that the implementation should be reworked as outlined above, before being made available in an MP build. -- from CyberSimian in the UK [/QUOTE]

Verification