[patch] Adressed a couple of playlist issues (1 Viewer)

[enco]

Hi,

making my first steps in C# (I'm a Delphi and scripting guy), I adressed the bugs reported here and here, being:
- tracks containing special characters in .m3u playlists were skipped as well as not displayed properly
- track lengths in .pls playlists were off by a factor of 1000 seconds
- relative paths in .pls playlists didn't work


Here's what I changed:

Core.PlayList.PlayListM3uIO.cs:
Line 59, old code:

using (file = new StreamReader(playlistFileName))

new code:

Encoding fileEncoding = Encoding.Default;
FileStream stream = File.Open(playlistFileName, FileMode.Open, FileAccess.Read, FileShare.Read);
using (file = new StreamReader(stream, fileEncoding, true))

This took care of the problem with special chars in .m3u playlists.


Core.PlayList.PlayListPLSIO.cs:
Commented out line 138

//duration *= 1000;

This fixed the faulty track length display.

Lines 142-146, old code:

if (tmp.IndexOf("http:") < 0 && tmp.IndexOf("mms:") < 0 && tmp.IndexOf("rtp:") < 0)
{
  MediaPortal.Util.Utils.GetQualifiedFilename(basePath, ref fileName);
  newItem.Type = PlayListItem.PlayListItemType.AudioStream;
}

New code (just inserted one LOC inbetween):

if (tmp.IndexOf("http:") < 0 && tmp.IndexOf("mms:") < 0 && tmp.IndexOf("rtp:") < 0)
{
  MediaPortal.Util.Utils.GetQualifiedFilename(basePath, ref fileName);
  newItem.FileName = fileName;
  newItem.Type = PlayListItem.PlayListItemType.AudioStream;
}

This fixed the handling of relative paths.

BTW I'm not sure if the assignment of the newItem.Type is correct in this last piece of code. But since it's been working for me so far, I left it alone. Someone with more inside knowledge may verify this.

Cheers...

 

[tomtom21000]

sounds great. I am no programmer, so I can´t say much to your changes.

But it is always appreciated if you:

# explain the changes on the forums (done! )
# upload your changes as full files to the sourceforge patches section: http://sourceforge.net/tracker/?atid=647927&group_id=107397&func=browse

tomtom

 

[enco]

Whoops, I see... thanks for the hint.
I uploaded the two source files to the patches section on SF.net now. Hope it helps