[Patch]Fix & improve vobsub-haali cooperation

Discussion in 'General Development (no feature request here!)' started by peterk2007, October 24, 2007.

  1. peterk2007

    peterk2007 Portal Member

    Joined:
    April 7, 2007
    Messages:
    15
    Likes Received:
    4
    Ratings:
    +4 / 0
    Home Country:
    Hungary Hungary
    Hi everyone,

    I've found out, that if Haali splitter installed with avi support, then vobsub autoload feature don't work on avi files with external subtitles (srt, sub, etc.). No matter how you set up vobsub, enable or disable haali's vobsub
    autoload feature, it just doesn't work. Adding vobsub in mediaportal as postprocessing filter also does not solve the problem, because vobsub won't be included in the graph on rendering.

    Since Haali's splitter otherwise works really great for avi-s too (for example handling avi files with multiple audio streams, etc) this haali bug (i guess) can be quite annoying.



    So I made this pach to fix this issue in mediaportal. It does the following:

    1. Looks for vobsub filter after the graph has been rendered.
    2. If vobsub is there - either the autoloading or the "normal" version - then checks if it is properly connected. Checks for both the video and subtitle pins.
    3. If the video pins are not connected, then inserts vobsub right before the vmr9 renderer.
    4. If the subtitle input pin is not connected, then looks for haali splitter, and if it is there, then connects haali's subtitle output pin (if any) to vobsub.
    5. Finally makes vobsub to refresh available subtitle streams (reloading available external subtitle info).

    So with this patch, basically and generally you will be able to fix "vobsub not loading issues". Simply add vobsub as postprocessing filter, and then vobsub will always load and connect properly into the graph providing subtitles whenever possible. (If you added vobsub as postprocessing filter, you can disable autoloading in vobsub config, and also in haali config.)

    This patch does not affect vobsub autoloading functionality. If vobsub autoloaded and connected properly, the patch does not touch it.

    Affected files: VideoPlayerVMR9.cs, VMR9.cs

    I used the latest SVN files (rev 16346)

    I have submitted the patch to the tracker: Here

    Cheers.
     
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. bmfrosty

    bmfrosty New Member

    Joined:
    November 25, 2007
    Messages:
    1
    Likes Received:
    0
    Ratings:
    +0 / 0
    Home Country:
    United States of America United States of America
    Was this patch ever applied? I'm using the 0.2.3.0 release and am running into this problem. I'm having to remux ogm+ssa files to work around the problem. :(
     
  4. Darre

    Darre Portal Pro

    Joined:
    April 21, 2007
    Messages:
    925
    Likes Received:
    80
    Ratings:
    +80 / 0
    Home Country:
    Norway Norway
    Im also having trouble gettings subs to show up in MP. About exactly the problem that should have been fixed by this patch actually..
     
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!