[Approved] Patch for Edition support (Haali)

Sebastiii
Country flag

Development Group
  • Team MediaPortal
  • November 12, 2007
    16,350
    113
    France
    Home Country
    France France
    • Thread starter
    • Moderator
    • #1
    Hi,

    This is the patch based on last svn 1.2.0 for add Edition Menu choice but work only with Haali (only can parse edition).
    Cheers,
    Seb.

    Edit : New patch to match with last SVN
    Edit : New patch to match with last 1.2.0SVN(r26525)
    Edit : New patch to match with last 1.2.0SVN(r26844)
     

    Attachments

    morpheus_xx
    Country flag

    Lead Dev MP2
  • Team MediaPortal
  • March 24, 2007
    11,188
    113
    Home Country
    Germany Germany
    AW: Patch for Edition support (Haali)

    can you explain what you mean with "Editions"? what is it used for?

    maybe it's interesting to add to MP2 :)
     

    Sebastiii
    Country flag

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,350
    113
    France
    Home Country
    France France
    • Thread starter
    • Moderator
    • #3
    Hi morpheus_xx

    Some mkv have Ordered Chapter to make virtual line time for intro of movie etc.
    And we can have too movie with 2 end (for example).
    Actually only Haali can manage it and parse this edition by defined pdwgroup (here 18).
    I have change code to detect it and set a menu OSD to have the possibility of choose it.

    I hope my explain was clear :)
    Cheers,
    Seb.

    PS : i can make screenshot :)
     

    Attachments

    Truri

    MP Donator
  • Premium Supporter
  • November 9, 2008
    192
    18
    Home Country
    Germany Germany
    AW: Patch for Edition support (Haali)

    That would be a really nice feature.

    +1
     

    esas

    Portal Pro
    November 14, 2006
    160
    18
    Home Country
    Norway Norway
    Yes! Miss this feature. Had to close MP and use WMP to see the alternative ending of "I am Legend" the other day. Hope this patch gets accepted.
     

    Sebastiii
    Country flag

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,350
    113
    France
    Home Country
    France France
    • Thread starter
    • Moderator
    • #7
    Hi commander197,

    For now only Haali support this, i hope that other splitter can manage ordered chapter and edition, Lavf splitter will add this later and i have try on MPC Matroska but so hard for me lol.

    Greets,
    Seb.
     

    Inker

    Retired Team Member
  • Premium Supporter
  • December 6, 2004
    2,055
    83
    I am not the right person to review this, but code looks clean to me, and it would make a fantastic feature for MP IMO.

    I'd vote to push this into SVN so it gets some test-coverage. Changes seem contained enough that reverting should cause any problems should we run into unexpected issues.
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    Top Bottom