[Approved] Patch for MPEI (min and max versions are backwards for TVServer dependency) (1 Viewer)

[cwchapma]

I've submitted a pull request that fixes the min and max version comparisons for a TVServer dependency. Is there anything special I need to do to have someone on the team consider it?

Thanks,
Clint

 

[Holzi]

Thanks!
@Developers

 

[seco]

I just had a quick look, there seems to be a lot of changes and the code is I guess something that is used elsewhere too.

Maybe @offbyone knows this area?

Also this kind of code is something we could really have Unit Tests for (and should have).

 

[offbyone]

I've seen your pull request, but need some time to look at it. Maybe will get to it on the weekend.

 

[cwchapma]

Still hoping this will be looked at and not forgotten

 

[offbyone]

Reviewed, and good to go in from my side.

The "many" changes for a small fix are there because cwchapma actually implemened it cleaner than it currently was.

The merge window for MP 1.4 is closed, I'll check back with the team when (now or next version) we can add this.
Thanks!

Mantis issue : http://mantis.team-mediaportal.com/view.php?id=4437

 

[cwchapma]

Thanks @offbyone!

 

[offbyone]

Merged to master. Thanks for submitting!

 

[Holzi]

Thanks @cwchapma and @offbyone