[patch] Missing end line characters in textscrollup control (1 Viewer)

zebons

Portal Pro
January 2, 2006
1,484
114
Hi,
I notice a bug with textscrollup controls : in some cases, end lines characters are missing. The problem didn't exist in previous versions.
If I replace in my skin the control by a simple textbox, there is no problem (but no scrolling of course...).
I compared the two codes GUITextScrollUpControl.cs and GUITextControl.cs and noticed a difference for the calcul of the dMaxWidth value.
So I took a look on SVN's version of the GUITextScrollUpControl.cs and found the origin of the difference in revision 10242 of that code.
At line 237 of the actuel code (215 in the previous one), I replace the code :
int dMaxWidth = _width - ixoff;
by
int dMaxWidth = _width + ixoff;
as it was previously and now it seems to work properly. See doc joined.

Can you validate my opinion and if it's good modify the actual code to integrate in future SVN ?
Thanks
 

-Manfred-

Retired Team Member
  • Premium Supporter
  • May 15, 2007
    728
    343
    Home Country
    Finland Finland
    I can confirm this. Long lines and last chars missing, quite annoying bug when scrolling EPG data. Please fix this.

    -M-
     

    Users who are viewing this thread

    Top Bottom