[Patch] My TV OSD / ZAPOSD stuttering fix (1 Viewer)

FlipGer

Retired Team Member
  • Premium Supporter
  • April 27, 2004
    2,658
    115
    47
    Leipzig, Germany
    Home Country
    Germany Germany
    Hi,

    regarding to this thread i took (again ;)) a look into the code and found the reason for the stuttering. The whole program database is read everytime the OSD is called or the channel is changed with the ZAPOSD.

    This is because of old instances util of TVUtil() in the ShowProgram() method. I changed this to the common m_util instance, which now is called once at the beginning. Also the channel m_channels list was refreshed on init, i moved this in the constructor.

    Patch ist on Sourceforge. :)

    Flip.
     

    SePPiE

    Portal Pro
    December 6, 2004
    66
    0
    The Netherlands
    hi flipger,

    Looking at the code, I can indeed see the advantages of this patch...
    good work!.
    I'm gonna try it tonight at home to check.

    I'm also gonna add an option to config to disable zap osd...
    This to acommodate for the people that don't want it.
     

    FlipGer

    Retired Team Member
  • Premium Supporter
  • April 27, 2004
    2,658
    115
    47
    Leipzig, Germany
    Home Country
    Germany Germany
    Hi SePPiE,

    you did the good work with this plugin! :) The stuttering was just a reason of copy and past of the OSD code. There was the origin of the bug. ;) Hopefully i did not collide with your coding?

    I have some more ideas for the ZAPOSD, perhaps you have an open ear:
    - Changing channel groups, for example with PageUP/DOWN
    - Then zapping only in the selected group

    Just my two cents.

    Looking forward to your next modifications! :)

    Flip.
     

    SePPiE

    Portal Pro
    December 6, 2004
    66
    0
    The Netherlands
    hi flipger,

    I dont mind that at all flipger, that's the beauty of opensource, don't ya think? :)
    Indeed, I copy pasted most of the code for the ZapOSD (I hate figuring stuff out AGAIN) lol...

    About your idea, you mean to switch to the group WHILE IN the zap-osd?
    That could be possible indeed.
    Coding wise it's not a big deal, so I would definatly look into that.

    Right now I'm busy with modifying zap-osd to handle three (or four) digit channel numbers and showing the channel number when entered in the zap-osd (or original osd depending if the user is alraedy in there or not).


    Other modification I'm doing is TV-Tome integration into MP... With the great help of Inker on that one..
     

    FlipGer

    Retired Team Member
  • Premium Supporter
  • April 27, 2004
    2,658
    115
    47
    Leipzig, Germany
    Home Country
    Germany Germany
    Hi,

    paddy69 said:
    Can we use this patch already, and yes wher to put the files of guitv.zip??

    If you use the patch, you will have to compile MP for your own. These files are just C# sources.

    But i provid a compiled dll for the latest release (0.1.0.8 ). Look here :)

    Flip.
     

    FlipGer

    Retired Team Member
  • Premium Supporter
  • April 27, 2004
    2,658
    115
    47
    Leipzig, Germany
    Home Country
    Germany Germany
    SePPiE:

    Yes, OpenSource is really a nice thing. And i also do most of the time copy and paste. ;)

    Group switching: Yeah, i am thinking of something like that. It was also already a feature request of some people to make it possible to change the group in fullscreen.
    And i think it then is more logical if the zapping cycles only through the channels of the selected group. So you could change e.g. to music group and than zap only through all your music channels. Just let it roll a bit through your mind. :)

    Flip.
     

    FlipGer

    Retired Team Member
  • Premium Supporter
  • April 27, 2004
    2,658
    115
    47
    Leipzig, Germany
    Home Country
    Germany Germany
    Hi,

    spiff: Nice it works! :)

    SePPiE: Would it be possible to enter milliseconds instead of seconds for the delaytimes? It would be nice, if i could choose 1500ms. :)

    Flip.
     

    Users who are viewing this thread

    Top Bottom