[Approved] - Patch to allow property keepaspectratio in thumbnailpanel

Discussion in 'Archive' started by pilehave, September 11, 2009.

  1. pilehave
    • Premium Supporter

    pilehave Community Skin Designer

    Joined:
    April 2, 2008
    Messages:
    2,566
    Likes Received:
    500
    Gender:
    Male
    Occupation:
    Technical consultant, marketing
    Location:
    Hornslet
    Ratings:
    +517 / 0
    Home Country:
    Denmark Denmark
    Hi

    Most movie-viewers use posters in the movie-views, in "My Videos" or "Moving Pictures". Ideally they should be the same size, but in case they are not it would be nice to be able to use the <keepaspectratio> property.

    In filmstrip the poster is resized to fit the measures given in textureWidth and textureHeight. This is for some reason not the case with thumbnailpanels.

    The incorporated solution at the moment is to set <thumbZoom> to true. this means that the thumbnail will crop the poster = not pretty.

    My solution is to patch GUIThumbnailPanel and allow usage of <keepaspectratio>

    I have attached two screenshots of before/after behaviour.

    Please not that the aspect ratio is also kept for the foldericon, this is not a problem as it is possible to define which to use, and you could therefor create one in posterformat :)



    [EDIT]Patch attached, I could have sworn that I had it uploaded already :( [/EDIT]
     

    Attached Files:

    • Like Like x 5
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. infinite.loop
    • Premium Supporter

    infinite.loop Retired Team Member

    Joined:
    December 26, 2004
    Messages:
    16,163
    Likes Received:
    3,861
    Gender:
    Male
    Location:
    127.0.0.1
    Ratings:
    +4,154 / 7
    Home Country:
    Austria Austria
    Show System Specs
    So, where is the patch? :)
    Featurefreeze starts tomorrow as you know, so it might allready be too late.
     
  4. pilehave
    • Premium Supporter

    pilehave Community Skin Designer

    Joined:
    April 2, 2008
    Messages:
    2,566
    Likes Received:
    500
    Gender:
    Male
    Occupation:
    Technical consultant, marketing
    Location:
    Hornslet
    Ratings:
    +517 / 0
    Home Country:
    Denmark Denmark
    Sorry, patch attached. Hope it makes it...
     
  5. Mr Hipp
    • Premium Supporter

    Mr Hipp Retired Team Member

    Joined:
    April 2, 2006
    Messages:
    1,261
    Likes Received:
    187
    Location:
    Malmö
    Ratings:
    +187 / 0
    Home Country:
    Sweden Sweden
    I have checked it and it looks good. Only minor issues like tag should be named "keepAspectRatio" otherwise it's good.

    Mr Hipp
     
  6. Mr Hipp
    • Premium Supporter

    Mr Hipp Retired Team Member

    Joined:
    April 2, 2006
    Messages:
    1,261
    Likes Received:
    187
    Location:
    Malmö
    Ratings:
    +187 / 0
    Home Country:
    Sweden Sweden
    Ok, I see why you have named it "keepaspectratio". It's a mess :)
     
  7. pilehave
    • Premium Supporter

    pilehave Community Skin Designer

    Joined:
    April 2, 2008
    Messages:
    2,566
    Likes Received:
    500
    Gender:
    Male
    Occupation:
    Technical consultant, marketing
    Location:
    Hornslet
    Ratings:
    +517 / 0
    Home Country:
    Denmark Denmark
    Yeah, in some controls it's one thing an in another it is different. The patch itself is pretty simple, but I think it makes good sense to be able to have same size covers in thumbview. Looks better to me :)

    You're a busy man these days Mr Hipp :D
     
  8. cul8er
    • Premium Supporter

    cul8er Retired Team Member

    Joined:
    August 31, 2006
    Messages:
    2,159
    Likes Received:
    2,682
    Ratings:
    +2,698 / 0
    Home Country:
    Sweden Sweden
  9. pilehave
    • Premium Supporter

    pilehave Community Skin Designer

    Joined:
    April 2, 2008
    Messages:
    2,566
    Likes Received:
    500
    Gender:
    Male
    Occupation:
    Technical consultant, marketing
    Location:
    Hornslet
    Ratings:
    +517 / 0
    Home Country:
    Denmark Denmark
  10. cul8er
    • Premium Supporter

    cul8er Retired Team Member

    Joined:
    August 31, 2006
    Messages:
    2,159
    Likes Received:
    2,682
    Ratings:
    +2,698 / 0
    Home Country:
    Sweden Sweden
    Hi,

    My misstake;) I read the post about the "channel name" fix and noticed that it was accepted and didn't read the status on this fix, sorry about that.

    best regards
    cul8er
     
    • Like Like x 1
  11. pilehave
    • Premium Supporter

    pilehave Community Skin Designer

    Joined:
    April 2, 2008
    Messages:
    2,566
    Likes Received:
    500
    Gender:
    Male
    Occupation:
    Technical consultant, marketing
    Location:
    Hornslet
    Ratings:
    +517 / 0
    Home Country:
    Denmark Denmark
    :p

    I updated the wiki with a small note about the channelname changes (my other patch). I think it's great that you make sure changes are documented!

    :D
     
    • Like Like x 2
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!