[Rejected] Patch to expose channelname of channel to skin (part 2) (1 Viewer)

[pilehave]

Hi!

My old patch https://forum.team-mediaportal.com/...etc-325/patch-expose-channel-name-skin-70273/ could use a brushup, since the exposed channelname was missing in both TVScheduler.cs and in TVGuideBase.cs.

This patch adds support for the following skin properties:

TVScheduler.cs (mytvschedulerServer.xml): #TV.RecordedTV.Channel
TVGuideBase.cs (mytvguide.xml + dialogTvGuide.xml): #TV.Guide.Channel

It is created against 25080 (RC1) but should be easy to adapt to recent SVN.

This would give skinners more freedom and keep the consistency of my first patch.



[edit] Added a different patch, as it looks to me that there was unreachable code in TVScheduler.cs that resulted in the channelname never being set.[/edit]

 

[chemelli]

pilehave,

don't we already have those exposed ? Am I missing something ?

Simone

 

[pilehave]

pilehave,

don't we already have those exposed ? Am I missing something ?

Simone

No, they are missing in both screens

 

[pilehave]

Bump?

 

[ncoH]

AW: Patch to expose channelname of channel to skin (part 2)

i would also like to have this...

 

[pilehave]

As far as I can tell, these changes are already in SVN. It is active for the tvguide screens, and I think it is for TVScheduler. Off course you need to schedule a recording before the channel-name is exposed.

Nico, are you missing this info from a screen? Please tell me which one so I can test it. I think this thread should have been closed some time back...

 

[ncoH]

AW: Re: Patch to expose channelname of channel to skin (part 2)

As far as I can tell, these changes are already in SVN. It is active for the tvguide screens, and I think it is for TVScheduler. Off course you need to schedule a recording before the channel-name is exposed.

Nico, are you missing this info from a screen? Please tell me which one so I can test it. I think this thread should have been closed some time back...

I tried #TV.Guide.Channel in mytvguide.xml but only the string is shown...

 

[SilentException]

I think you need to use #TV.Guide.ChannelName and/or #TV.Scheduled.Channel

pilehave, is this patch not needed then?

 

[ncoH]

AW: Re: Patch to expose channelname of channel to skin (part 2)

I think you need to use #TV.Guide.ChannelName and/or #TV.Scheduled.Channel

pilehave, is this patch not needed then?

#TV.Guide.ChannelName works.

 

[DieBagger]

So can we mark this as rejected/approved/no longer needed then?