[Rejected] pcr data in separate stream problem (1 Viewer)

[mvedrina]

Problem
Unable to stream in multiseat if pcr_pid is different than video/audio/teletext/subtitle pid.

Quick solution
Leave pcr_pid unchanged to point to original stream that contains pcr data.
pcr_pid will be faked only if pcr data is contained in any of video/audio/teletext/subtitle streams.
Patch file is included.

Possible proper solution
extract pcr data into separate stream with always the same pid
or
if pcr data is in separate stream then integrate it into video stream

Proof of concept (the quick one)
With this patch, timeshiftig file is prefectly readable with VLC player and for me everything is now working perfectly.

Possible drawbacks
Maybe pcr_pid that is changing can cause side efects.

Note
The possible patch that I included in bug report section on this subject is not valid, so don't use it.

 

[mvedrina]

Update:

It seems that patch included in previous post isnt't enough. It enabled streaming, but channel changes in certain order are blocking playback. I probably patched some other file on my system so it worked for me.

Still, my opinion is that faked pcr is causing streaming problems. Faked pcr pid shouldn't be (in the manner that is pathed now) same as faked vpid if video stream doesn't include pcr data. Also, changing fake_pcr_pid to 0x21 (as it was previously) enables streaming.

After this change tsreader on the client gets wrong stream duration so i suspect that the problem is in streaming server. If timeshifting is started with a channel that has different pcr_pid from vpid everinthing is fine. If timeshifting is started with a channel that has pcr_pid and vpid same, playback blocks.

 

[mvedrina]

I did more testing and I suggest to reject this patch.

There are many ways to get problematic channel on client PC. I tried to patch pcr_pid in PmtParser, on tswriter, even on tsreader and there are always some combination of programs that doesn't work.

I think that problem is specific to my IPTV provider and that only way to override this is to add fake_pcr_pid (for pmtparser in tswriter) for each IPTV channel in tv database.

 

[Mr Hipp]

So, it is.