[Rejected] Pictureslideshow replace black background (1 Viewer)

OnkelChris

Retired Team Member
  • Premium Supporter
  • October 17, 2007
    764
    59
    Home Country
    Germany Germany
    Hey guys,

    someone asked about having the black background in picture slideshow replaced. this is the first attempt for this.

    Changes:
    • replace black background with current image
    • darken the image in background
    • keep aspect ratio of zoomed part (background)

    todo (if people like the feature):
    • unsharpen the image
    • improve zoom area (for slideshow with ken burns)

    What it does?
    Replaced the black background in myPictures with the current shown picture.

    69289d1286552450-nie-wieder-schwarze-balken-bei-hochformat-17-38-55.png


    69290d1286552450-nie-wieder-schwarze-balken-bei-hochformat-17-39-05.png
     

    Attachments

    • patch_picture_bg.patch
      2.9 KB

    el_gato

    Portal Pro
    October 15, 2007
    189
    58
    Home Country
    Germany Germany
    AW: Pictureslideshow replace black background

    looks nice! will it be optional or is it supposed to replace the black bg?
     

    OnkelChris

    Retired Team Member
  • Premium Supporter
  • October 17, 2007
    764
    59
    Home Country
    Germany Germany
    AW: Pictureslideshow replace black background

    it just replaces the black background, but optional could be a good thing... will think about it
     

    OnkelChris

    Retired Team Member
  • Premium Supporter
  • October 17, 2007
    764
    59
    Home Country
    Germany Germany
    AW: Pictureslideshow replace black background

    had to update the patch. attachment of first post updated
     

    arion_p

    Retired Team Member
  • Premium Supporter
  • February 7, 2007
    3,373
    1,626
    Athens
    Home Country
    Greece Greece
    Hi,

    I have been discussing your patch with the team, and it seems the general consensus is that this new feature would not appeal to a wide audience. I am sure there are MP users that like this feature but I am also sure that the majority of MP users will at least want a way to disable it. This means that we would need another configuration option. Considering that several users find MP hard to configure due to the overwhelming number of options, we think adding another one for a feature not as widely needed would simply be wrong. As a result I have to reject this patch.

    I hope you understand the reasoning behind this decision, and I would like to thank you for your work nonetheless.

    PS: I am not sure if this is possible, but perhaps you could find a way to implement this as plugin. This way you could satisfy those users that do like/want the feature.
     

    OnkelChris

    Retired Team Member
  • Premium Supporter
  • October 17, 2007
    764
    59
    Home Country
    Germany Germany
    AW: Pictureslideshow replace black background

    :D for looking at my patch. i understand what you mean and it's no problem for me.
     

    Users who are viewing this thread

    Top Bottom