[fixed] PIN is shown in file dialog (1 Viewer)

[regeszter]

MediaPortal Version: 1.2.0 beta
MediaPortal Skin: b3w
Windows Version: Windows 7 32bit HUN
CPU Type: Intel E2160
HDD: Intel 40 GB SSD X25-V
Memory: 4GB DDR2 800
Motherboard: GA-P35-DS3
Video Card: ATI 4550 DDR3 512MB
Video Card Driver:
Sound Card:
Sound Card AC3:
Sound Card Driver:
1. TV Card: Leadtek 1800H DVB-T
1. TV Card Type: DVB-T
1. TV Card Driver:
2. TV Card: Haupppage PVR150 MCE
2. TV Card Type: analog
2. TV Card Driver:
3. TV Card:
3. TV Card Type:
3. TV Card Driver:
4. TV Card:
4. TV Card Type:
4. TV Card Driver:
MPEG2 Video Codec: MS DTV-DVD
MPEG2 Audio Codec: MS DTV-DVD
h.264 Video Codec: MS DTV-DVD
Satelite/CableTV Provider:
HTPC Case:
Cooling:
Power Supply:
Remote: MCE remote
TV: LG-37LC2R
TV - HTPC Connection: dvi

If I enter the pin in the file dialog (pin protected), the pin is showed instead of ****.

 

[elliottmc]

Hi,

This is a classic example of a hopelessly incomplete bug report.

Sorry to have a go at you, but there are clear bug reporting guidelines in the sticky thread in this forum.

Despite this, I have tried to reproduce the problem. I added a pin-protected share in the videos configuration section. The pin was shown as 'bullets', so not exposed there.

I then lauched MediaPortal and entered My Videos, and selected the pin-protected folder. I entered the pin, and the numbers were not shown (* instead as shown in the screenshot).

Since I cannot reproduce this problem, I have not posted logs.

Please, please, please, if you want the team to spend their valuable time trying to fix problems, at least explain what the problem is, and provide the logs. We don't care whether you think this is necessary. It always is.

[/rant]

Mark

PS. From now on, I am simply going to delete ALL threads without logs. If you are going to post saying that you will get the logs later, please consider waiting until you have the logs before posting.

 

[regeszter]

Sorry. I mean file menu pin protection! Not share protection.

 

[Seidelin]

Sorry. I mean file menu pin protection! Not share protection.

Give us the steps to reproduce, or it is impossible to guess what and where the bug is.
Screenshots may also help. We can't read your mind yet, although there might be a plugin under development for that.

 

[regeszter]

start MP config
go to GUI>File Menu
select enable file menu and enter a pin code (123)

start mp
go to a file
press f9
select file menu (you want delete the file)
enter the pin in keyboard/remote

you will show the pin instead of ***

 

[elliottmc]

Confirmed.

Can someone please mantis?

Mark

 

[Seidelin]

0003523: Pin code is shown on access for pin-protected file menu - MediaPortal Bugtracker

I have assigned it to myself. Working on a fix.

 

[Seidelin]

Can you try replacing windowplugins.dll with the attached file, and verify it fixes the issue?

 

[elliottmc]

Can you try replacing windowplugins.dll with the attached file, and verify it fixes the issue?

Yes, fixes it for me.

I didn't do extensive testing. I am sure you will know whether there is a possibility that this will break anything.

Mark

 

[Seidelin]

It cannot break anything. Before The pincode was asked for in a std. virtual keyboard. I made a "*" version of the same dialog only change is an extra line "keyboard.password = true;", and changed the pincode request to use that instead. Only question is if I found all places this bug occurs.

I fixed it for music, videos, and pictures. I don't think the file dialog is used anywhere else. At least I couldn't find other places the option is read.

From the patch it is apparent that there is a lot of copy-paste code in MP. I did nothing to clean this. That can wait for MP2