Reply to thread

Message

<blockquote data-quote="gemx" data-source="post: 560699" data-attributes="member: 26324">Hi,while working on the Atmolight plugin (see here <a href="https://forum.team-mediaportal.com/mediaportal-plugins-47/new-plugin-atmolight-process-plugin-update-13-01-2010-v1-1-a-75840/#post557386" target="_blank">https://forum.team-mediaportal.com/mediaportal-plugins-47/new-plugin-atmolight-process-plugin-update-13-01-2010-v1-1-a-75840/#post557386</a>) i noticed that the current method in the framebuffer always copies the whole image from the GPU which is a big CPU eater.Even more when you think about 1080i/p video content.In most cases it is enough to get only a small portion of the screen (e.g. for black bar detection) or get a smaller, resized image like e.g. in my case.I tried many different ways to capture the current screen content but the framegrabber was the only solution since it gets feeded directly by PlaneSurface.PresentImage(...).To give Plugin developers the freedom of choice how they would like the current image i made the attached small patch.It just exposes an OnNewFrameEvent from the framegrabber, where the current image is handed over before it's processed by the framegrabber itself.It's just a very small patch and until this event is not hooked to any code it won't be used anyway but maybe of great help to take CPU load from the framegrabber.Ok, I know, we have a feature freeze but this is not really a feature - it helps to reduce CPU load in MP if used by a plugin and if not it doesn't have any effect or side effect at all.This is a bit like begging - but please vote for &quot;yes&quot; because otherwise my (and probably that of many other) Atmolight Hardware will never run smooth with MP <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite7" alt=":p" title="Stick Out Tongue&nbsp; &nbsp; :p" loading="lazy" data-shortname=":p" />So, what do you think?Please vote <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile&nbsp; &nbsp; :)" loading="lazy" data-shortname=":)" /><img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite8" alt=":D" title="Big Grin&nbsp; &nbsp; :D" loading="lazy" data-shortname=":D" />The patch is here [CODE]Index: Core/Player/FrameGrabber.cs===================================================================--- Core/Player/FrameGrabber.cs&nbsp; &nbsp; (revision 24717)+++ Core/Player/FrameGrabber.cs&nbsp; &nbsp; (working copy)@@ -45,6 +45,9 @@&nbsp;&nbsp; &nbsp;&nbsp; private FrameGrabber() {}&nbsp;+&nbsp; &nbsp; public delegate void NewFrameHandler(Int16 width, Int16 height, Int16 arWidth, Int16 arHeight, uint pSurface);+&nbsp; &nbsp; public event NewFrameHandler OnNewFrame;+&nbsp; &nbsp;&nbsp; public static FrameGrabber GetInstance()&nbsp; &nbsp;&nbsp; {&nbsp; &nbsp; &nbsp;&nbsp; if (instance == null)@@ -120,6 +123,16 @@&nbsp; &nbsp;&nbsp; /// &lt;param name=&quot;pSurface&quot;&gt;&lt;/param&gt;&nbsp; &nbsp;&nbsp; public void OnFrame(Int16 width, Int16 height, Int16 arWidth, Int16 arHeight, uint pSurface)&nbsp; &nbsp;&nbsp; {+&nbsp; &nbsp; &nbsp; if (OnNewFrame != null)+&nbsp; &nbsp; &nbsp; {+&nbsp; &nbsp; &nbsp; &nbsp; try+&nbsp; &nbsp; &nbsp; &nbsp; {+&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; OnNewFrame(width, height, arWidth, arHeight, pSurface);+&nbsp; &nbsp; &nbsp; &nbsp; }+&nbsp; &nbsp; &nbsp; &nbsp; catch(Exception)+&nbsp; &nbsp; &nbsp; &nbsp; {+&nbsp; &nbsp; &nbsp; &nbsp; }+&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp;&nbsp; // Is GetCurrentImage() requesting a frame grab?&nbsp; &nbsp; &nbsp;&nbsp; if (!grabSample)&nbsp; &nbsp; &nbsp;&nbsp; {[/CODE]</blockquote>

[QUOTE="gemx, post: 560699, member: 26324"] Hi, while working on the Atmolight plugin (see here [url]https://forum.team-mediaportal.com/mediaportal-plugins-47/new-plugin-atmolight-process-plugin-update-13-01-2010-v1-1-a-75840/#post557386[/url]) i noticed that the current method in the framebuffer always copies the whole image from the GPU which is a big CPU eater. Even more when you think about 1080i/p video content. In most cases it is enough to get only a small portion of the screen (e.g. for black bar detection) or get a smaller, resized image like e.g. in my case. I tried many different ways to capture the current screen content but the framegrabber was the only solution since it gets feeded directly by PlaneSurface.PresentImage(...). To give Plugin developers the freedom of choice how they would like the current image i made the attached small patch. It just exposes an OnNewFrameEvent from the framegrabber, where the current image is handed over before it's processed by the framegrabber itself. It's just a very small patch and until this event is not hooked to any code it won't be used anyway but maybe of great help to take CPU load from the framegrabber. Ok, I know, we have a feature freeze but this is not really a feature - it helps to reduce CPU load in MP if used by a plugin and if not it doesn't have any effect or side effect at all. This is a bit like begging - but please vote for "yes" because otherwise my (and probably that of many other) Atmolight Hardware will never run smooth with MP :P So, what do you think? Please vote :) :thx: The patch is here [CODE] Index: Core/Player/FrameGrabber.cs =================================================================== --- Core/Player/FrameGrabber.cs (revision 24717) +++ Core/Player/FrameGrabber.cs (working copy) @@ -45,6 +45,9 @@ private FrameGrabber() {} + public delegate void NewFrameHandler(Int16 width, Int16 height, Int16 arWidth, Int16 arHeight, uint pSurface); + public event NewFrameHandler OnNewFrame; + public static FrameGrabber GetInstance() { if (instance == null) @@ -120,6 +123,16 @@ /// <param name="pSurface"></param> public void OnFrame(Int16 width, Int16 height, Int16 arWidth, Int16 arHeight, uint pSurface) { + if (OnNewFrame != null) + { + try + { + OnNewFrame(width, height, arWidth, arHeight, pSurface); + } + catch(Exception) + { + } + } // Is GetCurrentImage() requesting a frame grab? if (!grabSample) { [/CODE] [/QUOTE]

Verification