Reply to thread

Message

<blockquote data-quote="ojo" data-source="post: 3378" data-attributes="member: 10402">Finally done profiling some....Downloaded the new 0.0.0.10 version before starting out.Here is what i found in at typical run of the unmodified code:&nbsp;53,52% MediaPortal.GUI.Library.GUIControlFactory::Create&nbsp;23,69% MediaPortal.GUI.Library.GUIControlFactory::GetString&nbsp;18,91% MediaPortal.GUI.Library.GUIControlFactory::GetInt&nbsp; 4,46% MediaPortal.GUI.Library.GUIControlFactory::GetHexLooking at the code i found that for every GUIControl a whole lot of possible XML-elements are checked and read if present from the skin xml-file. Every time an element was tested it was via the SelectSingleNode method of the standard XML library. Allthough using a subset (a sub-node) this obvious takes a whole lot of processing time.So i spent some time thinking and came up with a possible work-around. Why not cache the XML-elements into a Hashtable using the name of the element as hash. Upon calling the Create method first thing was to cache the elements. Then I changed some (GetString, GetInt, GetHex and GetBool) of the read functions to return from the Hashtable instead of using the SelectSingleNode method.And the results from an equal typical run. The only differences are the changes described above.&nbsp; 4,14% MediaPortal.GUI.Library.GUIControlFactory::Create&nbsp; 0,27% MediaPortal.GUI.Library.GUIControlFactory::GetString&nbsp; 0,33% MediaPortal.GUI.Library.GUIControlFactory::GetInt&nbsp; 0,21% MediaPortal.GUI.Library.GUIControlFactory::GetHexNo, I didn't believe it either, so a did a second run. But I got approx. same results. And the code:[code]namespace MediaPortal.GUI.Library{&nbsp; public class GUIControlFactory&nbsp; {&nbsp; &nbsp; // just for making this profiling session easier&nbsp; &nbsp; private static bool iUseCache = true;&nbsp; &nbsp; &nbsp; &nbsp; // private cache for holding settings for each control instead of using SelectSingleNode&nbsp; &nbsp; // for each possible setting&nbsp; &nbsp; private System.Collections.Hashtable XmlCache = new System.Collections.Hashtable(30);&nbsp; &nbsp; &nbsp; &nbsp; public GUIControlFactory()&nbsp; &nbsp; {&nbsp; &nbsp; }...&nbsp; &nbsp; bool GetString(ref XmlNode RootNode, string strTag, ref string strStringValue)&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; if (iUseCache) // profiling&nbsp; &nbsp; &nbsp; { &nbsp; &nbsp; &nbsp; &nbsp; // new code&nbsp; &nbsp; &nbsp; &nbsp; if (!XmlCache.ContainsKey(strTag)) return false;&nbsp; &nbsp; &nbsp; &nbsp; string sValue = (string) XmlCache[strTag];&nbsp; &nbsp; &nbsp; &nbsp; if (sValue == null) return false;&nbsp; &nbsp; &nbsp; &nbsp; if (sValue == &quot;&quot;) return false;&nbsp; &nbsp; &nbsp; &nbsp; strStringValue = sValue;&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; else&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; // old code&nbsp; &nbsp; &nbsp; &nbsp; XmlNode node = RootNode.SelectSingleNode(strTag);&nbsp; &nbsp; &nbsp; &nbsp; if (node == null) return false;&nbsp; &nbsp; &nbsp; &nbsp; if (node.InnerText == null) return false;&nbsp; &nbsp; &nbsp; &nbsp; if (node.InnerText == &quot;&quot;) return false;&nbsp; &nbsp; &nbsp; &nbsp; strStringValue = node.InnerText;&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; return true;&nbsp; &nbsp; }...&nbsp; &nbsp; bool GetInt(ref XmlNode RootNode, string strTag, ref int iValue)&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; if (iUseCache) // profiling&nbsp; &nbsp; &nbsp; { &nbsp; &nbsp; &nbsp; &nbsp; // new code&nbsp; &nbsp; &nbsp; &nbsp; if (!XmlCache.ContainsKey(strTag)) return false;&nbsp; &nbsp; &nbsp; &nbsp; string sValue = (string) XmlCache[strTag];&nbsp; &nbsp; &nbsp; &nbsp; if (sValue == null) return false;&nbsp; &nbsp; &nbsp; &nbsp; if (sValue == &quot;&quot;) return false;&nbsp; &nbsp; &nbsp; &nbsp; try&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; iValue = System.Int32.Parse(sValue);&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; catch (Exception)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return false;&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; else&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; // old code&nbsp; &nbsp; &nbsp; &nbsp; XmlNode node = RootNode.SelectSingleNode(strTag);&nbsp; &nbsp; &nbsp; &nbsp; if (node == null) return false;&nbsp; &nbsp; &nbsp; &nbsp; if (node.InnerText == null) return false;&nbsp; &nbsp; &nbsp; &nbsp; if (node.InnerText == &quot;&quot;) return false;&nbsp; &nbsp; &nbsp; &nbsp; try&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; iValue = System.Int32.Parse(node.InnerText);&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; catch (Exception)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return false;&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; return true;&nbsp; &nbsp; }...&nbsp; &nbsp; bool GetHex(ref XmlNode RootNode, string strTag, ref long lValue)&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; if (iUseCache) // profiling&nbsp; &nbsp; &nbsp; { &nbsp; &nbsp; &nbsp; &nbsp; // new code&nbsp; &nbsp; &nbsp; &nbsp; if (!XmlCache.ContainsKey(strTag)) return false;&nbsp; &nbsp; &nbsp; &nbsp; string sValue = (string) XmlCache[strTag];&nbsp; &nbsp; &nbsp; &nbsp; if (sValue == null) return false;&nbsp; &nbsp; &nbsp; &nbsp; if (sValue == &quot;&quot;) return false;&nbsp; &nbsp; &nbsp; &nbsp; try&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; lValue = System.Int64.Parse(sValue);&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; catch (Exception)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return false;&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; else&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; // old code&nbsp; &nbsp; &nbsp; &nbsp; XmlNode node = RootNode.SelectSingleNode(strTag);&nbsp; &nbsp; &nbsp; &nbsp; if (node == null) return false;&nbsp; &nbsp; &nbsp; &nbsp; if (node.InnerText == null) return false;&nbsp; &nbsp; &nbsp; &nbsp; if (node.InnerText == &quot;&quot;) return false;&nbsp; &nbsp; &nbsp; &nbsp; try&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; lValue = System.Int64.Parse(node.InnerText, NumberStyles.HexNumber);&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; catch (Exception)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return false;&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; return true;&nbsp; &nbsp; }...&nbsp; &nbsp; bool GetBoolean(ref XmlNode RootNode, string strTag, ref bool bBoolValue)&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; if (iUseCache) // profiling&nbsp; &nbsp; &nbsp; { &nbsp; &nbsp; &nbsp; &nbsp; // new code&nbsp; &nbsp; &nbsp; &nbsp; if (!XmlCache.ContainsKey(strTag)) return false;&nbsp; &nbsp; &nbsp; &nbsp; string sValue = (string) XmlCache[strTag];&nbsp; &nbsp; &nbsp; &nbsp; if (sValue == null) return false;&nbsp; &nbsp; &nbsp; &nbsp; if (sValue == &quot;&quot;) return false;&nbsp; &nbsp; &nbsp; &nbsp; try&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (sValue == &quot;off&quot; || sValue == &quot;no&quot; || sValue == &quot;disabled&quot;) bBoolValue = false;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; else bBoolValue = true;&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; catch (Exception)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return false;&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; else&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; // old code&nbsp; &nbsp; &nbsp; &nbsp; XmlNode node = RootNode.SelectSingleNode(strTag);&nbsp; &nbsp; &nbsp; &nbsp; if (node == null) return false;&nbsp; &nbsp; &nbsp; &nbsp; if (node.InnerText == null) return false;&nbsp; &nbsp; &nbsp; &nbsp; if (node.InnerText == &quot;&quot;) return false;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; string strEnabled = node.InnerText;&nbsp; &nbsp; &nbsp; &nbsp; if (strEnabled == &quot;off&quot; || strEnabled == &quot;no&quot; || strEnabled == &quot;disabled&quot;) bBoolValue = false;&nbsp; &nbsp; &nbsp; &nbsp; else bBoolValue = true;&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; return true;&nbsp; &nbsp; }...[/code]The same can be used for the other Get'ters as well. GetAlignment, GetLong etc. I only did the most time consuming to prove the concept.Ojo</blockquote>

[QUOTE="ojo, post: 3378, member: 10402"] Finally done profiling some.... Downloaded the new 0.0.0.10 version before starting out. Here is what i found in at typical run of the unmodified code: [b] 53,52% MediaPortal.GUI.Library.GUIControlFactory::Create 23,69% MediaPortal.GUI.Library.GUIControlFactory::GetString 18,91% MediaPortal.GUI.Library.GUIControlFactory::GetInt 4,46% MediaPortal.GUI.Library.GUIControlFactory::GetHex [/b] Looking at the code i found that for every GUIControl a whole lot of possible XML-elements are checked and read if present from the skin xml-file. Every time an element was tested it was via the SelectSingleNode method of the standard XML library. Allthough using a subset (a sub-node) this obvious takes a whole lot of processing time. So i spent some time thinking and came up with a possible work-around. Why not cache the XML-elements into a Hashtable using the name of the element as hash. Upon calling the Create method first thing was to cache the elements. Then I changed some (GetString, GetInt, GetHex and GetBool) of the read functions to return from the Hashtable instead of using the SelectSingleNode method. And the results from an equal typical run. The only differences are the changes described above. [b] 4,14% MediaPortal.GUI.Library.GUIControlFactory::Create 0,27% MediaPortal.GUI.Library.GUIControlFactory::GetString 0,33% MediaPortal.GUI.Library.GUIControlFactory::GetInt 0,21% MediaPortal.GUI.Library.GUIControlFactory::GetHex [/b] No, I didn't believe it either, so a did a second run. But I got approx. same results. And the code: [code] namespace MediaPortal.GUI.Library { public class GUIControlFactory { // just for making this profiling session easier private static bool iUseCache = true; // private cache for holding settings for each control instead of using SelectSingleNode // for each possible setting private System.Collections.Hashtable XmlCache = new System.Collections.Hashtable(30); public GUIControlFactory() { } ... bool GetString(ref XmlNode RootNode, string strTag, ref string strStringValue) { if (iUseCache) // profiling { // new code if (!XmlCache.ContainsKey(strTag)) return false; string sValue = (string) XmlCache[strTag]; if (sValue == null) return false; if (sValue == "") return false; strStringValue = sValue; } else { // old code XmlNode node = RootNode.SelectSingleNode(strTag); if (node == null) return false; if (node.InnerText == null) return false; if (node.InnerText == "") return false; strStringValue = node.InnerText; } return true; } ... bool GetInt(ref XmlNode RootNode, string strTag, ref int iValue) { if (iUseCache) // profiling { // new code if (!XmlCache.ContainsKey(strTag)) return false; string sValue = (string) XmlCache[strTag]; if (sValue == null) return false; if (sValue == "") return false; try { iValue = System.Int32.Parse(sValue); } catch (Exception) { return false; } } else { // old code XmlNode node = RootNode.SelectSingleNode(strTag); if (node == null) return false; if (node.InnerText == null) return false; if (node.InnerText == "") return false; try { iValue = System.Int32.Parse(node.InnerText); } catch (Exception) { return false; } } return true; } ... bool GetHex(ref XmlNode RootNode, string strTag, ref long lValue) { if (iUseCache) // profiling { // new code if (!XmlCache.ContainsKey(strTag)) return false; string sValue = (string) XmlCache[strTag]; if (sValue == null) return false; if (sValue == "") return false; try { lValue = System.Int64.Parse(sValue); } catch (Exception) { return false; } } else { // old code XmlNode node = RootNode.SelectSingleNode(strTag); if (node == null) return false; if (node.InnerText == null) return false; if (node.InnerText == "") return false; try { lValue = System.Int64.Parse(node.InnerText, NumberStyles.HexNumber); } catch (Exception) { return false; } } return true; } ... bool GetBoolean(ref XmlNode RootNode, string strTag, ref bool bBoolValue) { if (iUseCache) // profiling { // new code if (!XmlCache.ContainsKey(strTag)) return false; string sValue = (string) XmlCache[strTag]; if (sValue == null) return false; if (sValue == "") return false; try { if (sValue == "off" || sValue == "no" || sValue == "disabled") bBoolValue = false; else bBoolValue = true; } catch (Exception) { return false; } } else { // old code XmlNode node = RootNode.SelectSingleNode(strTag); if (node == null) return false; if (node.InnerText == null) return false; if (node.InnerText == "") return false; string strEnabled = node.InnerText; if (strEnabled == "off" || strEnabled == "no" || strEnabled == "disabled") bBoolValue = false; else bBoolValue = true; } return true; } ... [/code] The same can be used for the other Get'ters as well. GetAlignment, GetLong etc. I only did the most time consuming to prove the concept. Ojo [/QUOTE]

Verification