Random Slideshow problem (1 Viewer)

[rekenaar]

Hi

The first time you select R.Slideshow in the Pictures module, the pictures are shown in normal order.
Second time you select R.Slideshow, the pictures are shown in random order.
One would expect that it should always show in random order. Or am I wrong?


Two log files attached:

1.txt:

• open MP
• Go to Pictures (only one folder defined with 5 pictures in it to make testing easier)
• Select R.Slideshow
• View pictures 1 to 5
• Quit MP

2.txt:

• open MP
• Go to Pictures (only one folder defined with 5 pictures in it to make testing easier)
• Select R.Slideshow
• 1.jpg will be shown first. Hit ESCAPE
• Select R.Slideshow
• View pictures 1 to 5 in RANDOM order
• Quit MP

For the purpose of this report, I used the BLUETWO skin.
MP 0.2.3 no SVN.
Windows XP.

I know about at least one other person who reported the same problem. I created this new thread to have it in the right forum.

 

[rekenaar]

Since I am using the slideshow feature on a daily basis, I would really like to have this bug fixed.

I never before looked at c# code, but since I have java programming experience, I decided to try and look at the code.

Downloaded VC# Express 2008.
Downloaded other requirements.
Downloaded source.

Inserted a few log statements and I now have a fix for this bug. Can one of the developers PLEASE PLEASE look at this and help me get it in SVN.

Under WindowPlugins, GUIPictures, GUISlideShow.cs:
LoadSettings() is somehow only called after StartSlideShow(). That is why all variables have the right values the second time - it is called, but too late for the first run.

If we can call it at the start of the slideshow, it works perfectly:

    public void StartSlideShow()
    {
      LoadSettings();

and

    public void StartSlideShow(string path)
    {
      LoadSettings();

This was confirmed by building the project and only replacing the WindowPlugins.dll file in my MP installation.

Please help me.

Secondly, by looking at the code, I noticed that the button R.Slideshow is for Recursive Slideshow and NOT Random Slideshow as I thought . I guess most of you knew that, but I am posting just in case someone else who did not know it, reads this.

Thank you.

 

[rekenaar]

Fixed source code

The fixed sourcecode file is attached.

Anyone willing to look at the 2 lines I changed and commit it to SVN please?

 

[rekenaar]

Fixed

Thank you rtv.

Merry Christmas.