Reply to thread

Message

<blockquote data-quote="pilehave" data-source="post: 789406" data-attributes="member: 71550">I tweaked the code a bit more. This is what I have so far, a cleanup is needed <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite2" alt=";)" title="Wink&nbsp; &nbsp; ;)" loading="lazy" data-shortname=";)" />[CODE]Index: VideoThumbCreator.cs===================================================================--- VideoThumbCreator.cs&nbsp; &nbsp; (revision 28214)+++ VideoThumbCreator.cs&nbsp; &nbsp; (working copy)@@ -33,7 +33,7 @@&nbsp;{&nbsp;&nbsp; public class VideoThumbCreator&nbsp;&nbsp; {-&nbsp; &nbsp; private static string ExtractApp = &quot;mtn.exe&quot;;+&nbsp; &nbsp; private static string ExtractApp = &quot;ffmpeg.exe&quot;;&nbsp; &nbsp;&nbsp; private static string ExtractorPath = Config.GetFile(Config.Dir.Base, &quot;MovieThumbnailer&quot;, ExtractApp);&nbsp; &nbsp;&nbsp; private static int PreviewColumns = 2;&nbsp; &nbsp;&nbsp; private static int PreviewRows = 2;@@ -112,7 +112,7 @@&nbsp; &nbsp; &nbsp;&nbsp; // Params for mplayer (outputs 00000001.jpg in video resolution into working dir) -vf scale=600:-3&nbsp; &nbsp; &nbsp;&nbsp; //string ExtractorArgs = string.Format(&quot; -noconsolecontrols -nosound -vo jpeg:quality=90 -vf scale -frames 1 -ss {0} \&quot;{1}\&quot;&quot;, &quot;501&quot;, aVideoPath);&nbsp;-&nbsp; &nbsp; &nbsp; // Params for mtm (http://moviethumbnail.sourceforge.net/usage.en.html)+&nbsp; &nbsp; &nbsp; // Params for mtn (http://moviethumbnail.sourceforge.net/usage.en.html)&nbsp; &nbsp; &nbsp;&nbsp; //&nbsp;&nbsp; -D 8&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; : edge detection; 0:off &gt;0:on; higher detects more; try -D4 -D6 or -D8&nbsp; &nbsp; &nbsp;&nbsp; //&nbsp;&nbsp; -B 420/E 600 : omit this seconds from the beginning / ending TODO: use pre- / postrecording values&nbsp; &nbsp; &nbsp;&nbsp; //&nbsp;&nbsp; -c 2 / r 2&nbsp;&nbsp; : # of column / # of rows@@ -136,13 +136,7 @@&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; postGapSec = 600;&nbsp; &nbsp; &nbsp;&nbsp; }&nbsp; &nbsp; &nbsp;&nbsp; bool Success = false;-&nbsp; &nbsp; &nbsp; string ExtractorArgs = string.Format(&quot; -D 6 -B {0} -E {1} -c {2} -r {3} -b {4} -t -i -w {5} -n -P \&quot;{6}\&quot;&quot;,-&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; preGapSec, postGapSec, PreviewColumns, PreviewRows, blank, 0, aVideoPath);-&nbsp; &nbsp; &nbsp; string ExtractorFallbackArgs = string.Format(-&nbsp; &nbsp; &nbsp; &nbsp; &quot; -D 8 -B {0} -E {1} -c {2} -r {3} -b {4} -t -i -w {5} -n -P \&quot;{6}\&quot;&quot;, 0, 0, PreviewColumns, PreviewRows, blank,-&nbsp; &nbsp; &nbsp; &nbsp; 0, aVideoPath);-&nbsp; &nbsp; &nbsp; // Honour we are using a unix app-&nbsp; &nbsp; &nbsp; ExtractorArgs = ExtractorArgs.Replace('\\', '/');+&nbsp; &nbsp; &nbsp;&nbsp; try&nbsp; &nbsp; &nbsp;&nbsp; {&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; // Use this for the working dir to be on the safe side@@ -150,16 +144,19 @@&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; string OutputThumb = string.Format(&quot;{0}_s{1}&quot;, Path.ChangeExtension(aVideoPath, null), &quot;.jpg&quot;);&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; string ShareThumb = OutputThumb.Replace(&quot;_s.jpg&quot;, &quot;.jpg&quot;);&nbsp;+&nbsp; &nbsp; &nbsp; &nbsp; string ExtractorArgs = string.Format(&quot; -ss {0} -itsoffset -5 -i \&quot;{1}\&quot; -vframes 1 \&quot;{2}\&quot;&quot;, preGapSec, aVideoPath, OutputThumb);+&nbsp; &nbsp; &nbsp; &nbsp; string ExtractorFallbackArgs = string.Format(&quot; -ss 60 -itsoffset -5 -i \&quot;{1}\&quot; -vframes 1 \&quot;{2}\&quot;&quot;, preGapSec, aVideoPath, OutputThumb);+&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; if ((LeaveShareThumb &amp;&amp; !Util.Utils.FileExistsInCache(ShareThumb))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; // No thumb in share although it should be there&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; || (!LeaveShareThumb &amp;&amp; !Util.Utils.FileExistsInCache(aThumbPath)))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; // No thumb cached and no chance to find it in share&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; {-&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; //Log.Debug(&quot;VideoThumbCreator: No thumb in share {0} - trying to create one with arguments: {1}&quot;, ShareThumb, ExtractorArgs);+&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Log.Debug(&quot;VideoThumbCreator: No thumb in share {0} - trying to create one with arguments: {1}&quot;, ShareThumb, ExtractorArgs);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; Success = Utils.StartProcess(ExtractorPath, ExtractorArgs, TempPath, 15000, true, GetMtnConditions());&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; if (!Success)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; {-&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // Maybe the pre-gap was too large or not enough sharp &amp; light scenes could be caught+&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // Maybe it takes more than 15 seconds to create the thumbnail, try fallback arguments&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; Thread.Sleep(100);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; Success = Utils.StartProcess(ExtractorPath, ExtractorFallbackArgs, TempPath, 30000, true, GetMtnConditions());&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; if (!Success)@@ -172,7 +169,7 @@&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; Utils.KillProcess(Path.ChangeExtension(ExtractApp, null));&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; try&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; {-&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // remove the _s which mdn appends to its files+&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // remove the _s which mtn appends to its files&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; File.Move(OutputThumb, ShareThumb);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; catch (FileNotFoundException)[/CODE]</blockquote>

[QUOTE="pilehave, post: 789406, member: 71550"] I tweaked the code a bit more. This is what I have so far, a cleanup is needed ;) [CODE] Index: VideoThumbCreator.cs =================================================================== --- VideoThumbCreator.cs (revision 28214) +++ VideoThumbCreator.cs (working copy) @@ -33,7 +33,7 @@ { public class VideoThumbCreator { - private static string ExtractApp = "mtn.exe"; + private static string ExtractApp = "ffmpeg.exe"; private static string ExtractorPath = Config.GetFile(Config.Dir.Base, "MovieThumbnailer", ExtractApp); private static int PreviewColumns = 2; private static int PreviewRows = 2; @@ -112,7 +112,7 @@ // Params for mplayer (outputs 00000001.jpg in video resolution into working dir) -vf scale=600:-3 //string ExtractorArgs = string.Format(" -noconsolecontrols -nosound -vo jpeg:quality=90 -vf scale -frames 1 -ss {0} \"{1}\"", "501", aVideoPath); - // Params for mtm (http://moviethumbnail.sourceforge.net/usage.en.html) + // Params for mtn (http://moviethumbnail.sourceforge.net/usage.en.html) // -D 8 : edge detection; 0:off >0:on; higher detects more; try -D4 -D6 or -D8 // -B 420/E 600 : omit this seconds from the beginning / ending TODO: use pre- / postrecording values // -c 2 / r 2 : # of column / # of rows @@ -136,13 +136,7 @@ postGapSec = 600; } bool Success = false; - string ExtractorArgs = string.Format(" -D 6 -B {0} -E {1} -c {2} -r {3} -b {4} -t -i -w {5} -n -P \"{6}\"", - preGapSec, postGapSec, PreviewColumns, PreviewRows, blank, 0, aVideoPath); - string ExtractorFallbackArgs = string.Format( - " -D 8 -B {0} -E {1} -c {2} -r {3} -b {4} -t -i -w {5} -n -P \"{6}\"", 0, 0, PreviewColumns, PreviewRows, blank, - 0, aVideoPath); - // Honour we are using a unix app - ExtractorArgs = ExtractorArgs.Replace('\\', '/'); + try { // Use this for the working dir to be on the safe side @@ -150,16 +144,19 @@ string OutputThumb = string.Format("{0}_s{1}", Path.ChangeExtension(aVideoPath, null), ".jpg"); string ShareThumb = OutputThumb.Replace("_s.jpg", ".jpg"); + string ExtractorArgs = string.Format(" -ss {0} -itsoffset -5 -i \"{1}\" -vframes 1 \"{2}\"", preGapSec, aVideoPath, OutputThumb); + string ExtractorFallbackArgs = string.Format(" -ss 60 -itsoffset -5 -i \"{1}\" -vframes 1 \"{2}\"", preGapSec, aVideoPath, OutputThumb); + if ((LeaveShareThumb && !Util.Utils.FileExistsInCache(ShareThumb)) // No thumb in share although it should be there || (!LeaveShareThumb && !Util.Utils.FileExistsInCache(aThumbPath))) // No thumb cached and no chance to find it in share { - //Log.Debug("VideoThumbCreator: No thumb in share {0} - trying to create one with arguments: {1}", ShareThumb, ExtractorArgs); + Log.Debug("VideoThumbCreator: No thumb in share {0} - trying to create one with arguments: {1}", ShareThumb, ExtractorArgs); Success = Utils.StartProcess(ExtractorPath, ExtractorArgs, TempPath, 15000, true, GetMtnConditions()); if (!Success) { - // Maybe the pre-gap was too large or not enough sharp & light scenes could be caught + // Maybe it takes more than 15 seconds to create the thumbnail, try fallback arguments Thread.Sleep(100); Success = Utils.StartProcess(ExtractorPath, ExtractorFallbackArgs, TempPath, 30000, true, GetMtnConditions()); if (!Success) @@ -172,7 +169,7 @@ Utils.KillProcess(Path.ChangeExtension(ExtractApp, null)); try { - // remove the _s which mdn appends to its files + // remove the _s which mtn appends to its files File.Move(OutputThumb, ShareThumb); } catch (FileNotFoundException) [/CODE] [/QUOTE]

Verification