RecordingDetail class has a hardcoded value for the recordings extension (1 Viewer)

johnzered

Retired Team Member
  • Premium Supporter
  • April 20, 2008
    358
    80
    Home Country
    Finland Finland
    As the title says, hardcoded extension for recordings...

    From what I can see the hardcoded extension variable (recEngineExt) in MakeFileName is only used from scheduler class line 625 when a recordingspath is made:
    recording.MakeFileName(cardInfo.Card.RecordingFolder);
    recording.CardInfo = cardInfo;
    Log.Write("Scheduler : record to {0}", recording.FileName);

    To produce a logentry, going further in the code in scheduler.cs when the recording starts it sends filename as a parameter to StartRecording when it returns fileName has the correct extension so for the moment it looks like it is only the log line that becomes wrong. But i suppose this could be missused if only RecordingDetail.MakeFileName is used somewhere.

    string fileName = recording.FileName;
    if (false == _controller.StartRecording(ref _user, ref fileName, false, 0))
    {
    return false;
    }

    log output (notice first line has an mpg extension=wrong the rest have .ts):
    ...
    2008-08-01 16:39:16.465000 [10]: Scheduler : record to C:\ProgramData\Team MediaPortal\MediaPortal TV Server\recordings\world trade center - CANAL+ HITS - 2008-08-01.mpg
    2008-08-01 16:39:16.470000 [13]: card: StartRecording 1 C:\ProgramData\Team MediaPortal\MediaPortal TV Server\recordings\world trade center - CANAL+ HITS - 2008-08-01.ts
    2008-08-01 16:39:16.471000 [13]: StartRecording to C:\ProgramData\Team MediaPortal\MediaPortal TV Server\recordings\world trade center - CANAL+ HITS - 2008-08-01.ts
    2008-08-01 16:39:16.472000 [13]: subch:0 StartRecord(C:\ProgramData\Team MediaPortal\MediaPortal TV Server\recordings\world trade center - CANAL+ HITS - 2008-08-01.ts)
    2008-08-01 16:39:16.473000 [13]: subch:0 record transport stream mode
    2008-08-01 16:39:16.474000 [13]: subch:0 StartRecording...
    ...

    One possible solution as I see it would be that instead of passing just a recordingpath string, pass the cardinfo to the MakeFileName method and that way it would be possible to determine what recordingformat that card is using...


    EDIT: Sorry for posting in wrong forum, can someone move it to the tv-section?

    //johnzered
     

    tourettes

    Retired Team Member
  • Premium Supporter
  • January 7, 2005
    17,301
    4,800
    Its a bug indeed, but so small that I havent ever even thought about fixing it :) Maybe in the future when there arent anything else left to be fixed :)
     

    Users who are viewing this thread

    Top Bottom