Recordings improvement (1 Viewer)

[Swede]

I think that, what to be expected, when entering My Recordings, is that all deleted and invalid recordings are gone. Only the ones you can watch are there. No more angry wife.

I have compiled a TvPlugin.dll that does that, even if you have deleted the files in other ways than from within MP. It's for ver. 1.0.0.22029

How about implementing this?

 

[Gixxer]

u've got my vote !!!!

 

[Swede]

Of course, it would be even better if there also was a check for recordings that are in the folder, but not in the database. I'll see if that is easy to add.

Edit: ...nope! ...not easy.

 

[Swede]

Patch for those who wants it:

Index: TVLibrary/TvPlugin/TvPlugin/TvRecorded.cs
===================================================================
--- TVLibrary/TvPlugin/TvPlugin/TvRecorded.cs	(revision 22029)
+++ TVLibrary/TvPlugin/TvPlugin/TvRecorded.cs	(working copy)
@@ -439,7 +439,11 @@
 
     protected override void OnPageLoad()
     {
+
       base.OnPageLoad();
+        DeleteInvalidRecordings(); //Added by Swede
+        Log.Info("DeleteInvalidRecordings - Swede"); //Added by Swede
+
       if (btnCompress != null)
       {
         btnCompress.Visible = false;
@@ -1633,6 +1637,16 @@
         if (!server.IsRecordingValid(rec.IdRecording))
         {
           server.DeleteRecording(rec.IdRecording);
+          
+          CacheManager.Clear();//Added by Swede
+          LoadDirectory();//Added by Swede
+          while (_iSelectedItem >= GetItemCount() && _iSelectedItem > 0)//Added by Swede
+          {//Added by Swede
+              _iSelectedItem--;//Added by Swede
+          }//Added by Swede
+
+          GUIControl.SelectItemControl(GetID, facadeView.GetID, _iSelectedItem);//Added by Swede
+
         }
       }
     }

Edit: This is now implemented in Disaster's MediaPortal Release

 

[misterd]

I just added this patch to SVN.



MisterD

 

[nicx]

hi,

is this patch included only in the disaster123 edition or in the standard 1.1 svn branch too?

nicx...

 

[Swede]

I just added this patch to SVN.



MisterD

You missed this (Yes it is)

 

[nicx]

i think you mena this one: 0002368: TvPlugin should remove invalid recordings when entering TvRecorded - MediaPortal Bugtracker

but unfortunately its not working for me with the actual svn. i delete the files on the network share and they still are listed in the recordings section of the client.

i found a bug in mantis: 0002636: Deleted recordings are not removed from database - MediaPortal Bugtracker

its a pitty that thit bug will not be fixed in 1.1 but only in a future version

nicx...

 

[Swede]

You're right... I haven't noticed. Pity