home
products
contribute
download
documentation
forum
Home
Forums
New posts
Search forums
What's new
New posts
All posts
Latest activity
Members
Registered members
Current visitors
Donate
Log in
Register
What's new
Search
Search
Search titles only
By:
New posts
Search forums
Search titles only
By:
Menu
Log in
Register
Navigation
Install the app
Install
More options
Contact us
Close Menu
Forums
MediaPortal 2
Feature Requests
Series : Request for features
Contact us
RSS
JavaScript is disabled. For a better experience, please enable JavaScript in your browser before proceeding.
You are using an out of date browser. It may not display this or other websites correctly.
You should upgrade or use an
alternative browser
.
Reply to thread
Message
<blockquote data-quote="chefkoch" data-source="post: 975670" data-attributes="member: 10438"><p>@<a href="https://forum.team-mediaportal.com/members/morpheus_xx.48495/" target="_blank">morpheus_xx</a></p><p>I can confirm the IMDB id detection is still working fine after merging the changes to your branch.</p><p> </p><p>A few other comments/thoughts:</p><p>(Samples for Matroska tags can be found in <a href="http://wiki.team-mediaportal.com/2_MEDIAPORTAL_2/Reference/MkvMatcher" target="_blank">wiki</a>.)</p><p> </p><p><strong>FirstAired - episode</strong></p><p>In commit <a href="https://github.com/MediaPortal/MediaPortal-2/commit/7bcb1cf044a1a4ee9bfb9ef3d8535a7dcf628931" target="_blank">7bcb1cf044a1a4ee9bfb9ef3d8535a7dcf628931</a> you added the new field FirstAired.</p><p>We are also reading the the release date for episodes from <a href="https://github.com/MediaPortal/MediaPortal-2/blob/dev/MediaPortal/Source/Extensions/MetadataExtractors/SeriesMetadataExtractor/NameMatchers/MatroskaMatcher.cs#L74-L81" target="_blank">Matroska tags</a> but write only the year into the MediaAspect.</p><p>I would have create a new branch based on yours, to change and add filling the FirstAired with that information as well, but was not sure whether I should have renamed the <a href="https://github.com/MediaPortal/MediaPortal-2/blob/dev/MediaPortal/Source/Extensions/MetadataExtractors/MatroskaLib/MatroskaConsts.cs#L43" target="_blank">MatroskaConsts </a>as well.</p><p> </p><p>We also might need add an additional regular expression to read the first aired date from file/folder names.</p><p> </p><p><strong>FirstAired - series</strong></p><p>Besided the <a href="http://thetvdb.com/wiki/index.php/API:Base_Episode_Record" target="_blank">FirstAired information on episode level</a>, which is useful for detection (<a href="http://thetvdb.com/wiki/index.php/API:GetEpisodeByAirDate" target="_blank">API</a>) and presentation within GUI it is also possible to get the <a href="http://thetvdb.com/wiki/index.php/API:Base_Series_Record" target="_blank">FirstAired information on series level</a>, which at least is useful for presentation within GUI.</p><p>Does this needs to be added to the SeriesAspect as well?</p><p>FirstAired/ReleaseDate on series level is not read from <a href="https://github.com/MediaPortal/MediaPortal-2/blob/dev/MediaPortal/Source/Extensions/MetadataExtractors/MatroskaLib/MatroskaConsts.cs#L37" target="_blank">MatroskaFiles</a>, yet.</p><p> </p><p><strong>FirstAired - season</strong></p><p>Within MatroskaLib there is also a SeasonYear listed, not sure if it is used or even needed at all: <a href="https://github.com/MediaPortal/MediaPortal-2/blob/dev/MediaPortal/Source/Extensions/MetadataExtractors/MatroskaLib/MatroskaConsts.cs#L37" target="_blank">https://github.com/MediaPortal/MediaPortal-2/blob/dev/MediaPortal/Source/Extensions/MetadataExtractors/MatroskaLib/MatroskaConsts.cs#L37</a></p><p> </p><p><strong>IsCompleteMatch</strong></p><p>If we are reading also the FirstAired date, an episode can be identified uniquely even without the season/episode index.</p><p>Do we need to change the check whether an episode is a complete match?</p><p><a href="https://github.com/MediaPortal/MediaPortal-2/blob/dev/MediaPortal/Source/Core/MediaPortal.Common/MediaManagement/Helpers/SeriesInfo.cs#L85-L91" target="_blank">https://github.com/MediaPortal/MediaPortal-2/blob/dev/MediaPortal/Source/Core/MediaPortal.Common/MediaManagement/Helpers/SeriesInfo.cs#L85-L91</a></p><p><a href="https://github.com/MediaPortal/MediaPortal-2/blob/dev/MediaPortal/Source/Core/MediaPortal.Common/MediaManagement/Helpers/SeriesInfo.cs#L185-L196" target="_blank">https://github.com/MediaPortal/MediaPortal-2/blob/dev/MediaPortal/Source/Core/MediaPortal.Common/MediaManagement/Helpers/SeriesInfo.cs#L185-L196</a></p><p><a href="https://github.com/MediaPortal/MediaPortal-2/blob/dev/MediaPortal/Source/Extensions/MetadataExtractors/SeriesMetadataExtractor/SeriesMetadataExtractor.cs#L98-L116" target="_blank">https://github.com/MediaPortal/MediaPortal-2/blob/dev/MediaPortal/Source/Extensions/MetadataExtractors/SeriesMetadataExtractor/SeriesMetadataExtractor.cs#L98-L116</a></p><p> </p><p> </p><p> </p><p></p><p> </p><p>This is included in <a href="https://github.com/MediaPortal/MediaPortal-2/commit/7bcb1cf044a1a4ee9bfb9ef3d8535a7dcf628931" target="_blank">commit 7bcb1cf044a1a4ee9bfb9ef3d8535a7dcf628931</a>.</p><p> </p><p>I am not sure for what this property is being used in future, but are you sure you this will be a unique string?</p><p>In example:</p><p>Shamelss:</p><p><a href="http://thetvdb.com/?tab=series&id=161511&lid=14" target="_blank">http://thetvdb.com/?tab=series&id=161511&lid=14</a></p><p><a href="http://thetvdb.com/?tab=series&id=78846&lid=7" target="_blank">http://thetvdb.com/?tab=series&id=78846&lid=7</a></p><p>Ok, in English it is called/identified as 'Shameless (US)' but in German it is not.</p><p>And in general we can not assume no other shows are called the same.</p></blockquote><p></p>
[QUOTE="chefkoch, post: 975670, member: 10438"] @[URL='https://forum.team-mediaportal.com/members/morpheus_xx.48495/']morpheus_xx[/URL] I can confirm the IMDB id detection is still working fine after merging the changes to your branch. A few other comments/thoughts: (Samples for Matroska tags can be found in [URL='http://wiki.team-mediaportal.com/2_MEDIAPORTAL_2/Reference/MkvMatcher']wiki[/URL].) [B]FirstAired - episode[/B] In commit [URL='https://github.com/MediaPortal/MediaPortal-2/commit/7bcb1cf044a1a4ee9bfb9ef3d8535a7dcf628931']7bcb1cf044a1a4ee9bfb9ef3d8535a7dcf628931[/URL] you added the new field FirstAired. We are also reading the the release date for episodes from [URL='https://github.com/MediaPortal/MediaPortal-2/blob/dev/MediaPortal/Source/Extensions/MetadataExtractors/SeriesMetadataExtractor/NameMatchers/MatroskaMatcher.cs#L74-L81']Matroska tags[/URL] but write only the year into the MediaAspect. I would have create a new branch based on yours, to change and add filling the FirstAired with that information as well, but was not sure whether I should have renamed the [URL='https://github.com/MediaPortal/MediaPortal-2/blob/dev/MediaPortal/Source/Extensions/MetadataExtractors/MatroskaLib/MatroskaConsts.cs#L43']MatroskaConsts [/URL]as well. We also might need add an additional regular expression to read the first aired date from file/folder names. [B]FirstAired - series[/B] Besided the [URL='http://thetvdb.com/wiki/index.php/API:Base_Episode_Record']FirstAired information on episode level[/URL], which is useful for detection ([URL='http://thetvdb.com/wiki/index.php/API:GetEpisodeByAirDate']API[/URL]) and presentation within GUI it is also possible to get the [URL='http://thetvdb.com/wiki/index.php/API:Base_Series_Record']FirstAired information on series level[/URL], which at least is useful for presentation within GUI. Does this needs to be added to the SeriesAspect as well? FirstAired/ReleaseDate on series level is not read from [URL='https://github.com/MediaPortal/MediaPortal-2/blob/dev/MediaPortal/Source/Extensions/MetadataExtractors/MatroskaLib/MatroskaConsts.cs#L37']MatroskaFiles[/URL], yet. [B]FirstAired - season[/B] Within MatroskaLib there is also a SeasonYear listed, not sure if it is used or even needed at all: [url]https://github.com/MediaPortal/MediaPortal-2/blob/dev/MediaPortal/Source/Extensions/MetadataExtractors/MatroskaLib/MatroskaConsts.cs#L37[/url] [B]IsCompleteMatch[/B] If we are reading also the FirstAired date, an episode can be identified uniquely even without the season/episode index. Do we need to change the check whether an episode is a complete match? [url]https://github.com/MediaPortal/MediaPortal-2/blob/dev/MediaPortal/Source/Core/MediaPortal.Common/MediaManagement/Helpers/SeriesInfo.cs#L85-L91[/url] [url]https://github.com/MediaPortal/MediaPortal-2/blob/dev/MediaPortal/Source/Core/MediaPortal.Common/MediaManagement/Helpers/SeriesInfo.cs#L185-L196[/url] [url]https://github.com/MediaPortal/MediaPortal-2/blob/dev/MediaPortal/Source/Extensions/MetadataExtractors/SeriesMetadataExtractor/SeriesMetadataExtractor.cs#L98-L116[/url] This is included in [URL='https://github.com/MediaPortal/MediaPortal-2/commit/7bcb1cf044a1a4ee9bfb9ef3d8535a7dcf628931']commit 7bcb1cf044a1a4ee9bfb9ef3d8535a7dcf628931[/URL]. I am not sure for what this property is being used in future, but are you sure you this will be a unique string? In example: Shamelss: [url]http://thetvdb.com/?tab=series&id=161511&lid=14[/url] [url]http://thetvdb.com/?tab=series&id=78846&lid=7[/url] Ok, in English it is called/identified as 'Shameless (US)' but in German it is not. And in general we can not assume no other shows are called the same. [/QUOTE]
Insert quotes…
Verification
Post reply
Forums
MediaPortal 2
Feature Requests
Series : Request for features
Contact us
RSS
Top
Bottom
