[Approved] Show DVB-S2 as channel type (1 Viewer)

[Vasilich]

this patch shows DVB-S2 as value for "Mapped cardtypes" column in TVSetup - TV Channels if channel has DVB-S2 properties filled. Detection of DVB-S2 is taken from scan routine where DVB-S2 channels scanning can be disabled (function "Scan" in CardDvbS.cs).

 

[Vasilich]

any comment on it after 1 week and 66 views?

 

[Wbunaarf]

Hi,

I've applied the patch, and it works. I don't have any comments on the code itself, but I believe that if S and S2 are to be separated so should T and T2 be. (Also, it would be nice to have this indicated on the cards as well.)

//Johannes

 

[Vasilich]

thanks for testing.
1. where should it be indicated for a card?
2. as i have no experience with DVB-T/T2 and cannot find information on which parameters can be defined whether the channel is DVB-T2, i cannot implement it for T2.

 

[mm1352000]

Hi Vasilich

I agree with Johannes - if you want to separate S and S2 then you should also separate T and T2... but I don't think that is possible. Ignoring that for the moment, I also don't think the current patch is technically correct/complete. DVB-S2 transponders can have DVB-S2 specific FEC rates or modulation schemes without needing to have the pilot on or use a lower roll-off. In other words, I think you need to check for those FEC rates and modulation schemes as well as the pilot and roll-off values.

Getting back to DVB-T2: at this stage there is absolutely no difference in the tuning parameters that are needed to tune to DVB-T2 muxes. It is just frequency and bandwidth as with DVB-T. That means there is no way to identify DVB-T2 channels through tuning parameters. Unless you go and add a separate DVB-T2 flag that has no effect for tuning then it will not be possible to identify T2...

mm

 

[Wbunaarf]

Hi,

1. where should it be indicated for a card?

I'd say here would be a good place:

However, the question is where to get the cards capabilities...

//Johannes

 

[Vasilich]

mm: after some reading of DVB-s and DVB-S2 standards i ended up at followed code

      if ( IsDVBS && 
           (Modulation != (int)DirectShowLib.BDA.ModulationType.Mod[B]16Qam[/B]) &&
           (    RollOff == (int)DirectShowLib.BDA.RollOff.Twenty     ||
                RollOff == (int)DirectShowLib.BDA.RollOff.TwentyFive ||
                Pilot == (int)DirectShowLib.BDA.Pilot.On ||
                Modulation == (int)DirectShowLib.BDA.ModulationType.Mod[B]16Apsk[/B] ||
                Modulation == (int)DirectShowLib.BDA.ModulationType.Mod[B]32Apsk[/B] ||
                InnerFecRate == (int)DirectShowLib.BDA.BinaryConvolutionCodeRate.Rate3_5  ||
                InnerFecRate == (int)DirectShowLib.BDA.BinaryConvolutionCodeRate.Rate4_5  ||
                InnerFecRate == (int)DirectShowLib.BDA.BinaryConvolutionCodeRate.Rate5_11 ||
                InnerFecRate == (int)DirectShowLib.BDA.BinaryConvolutionCodeRate.Rate1_4  ||
                InnerFecRate == (int)DirectShowLib.BDA.BinaryConvolutionCodeRate.Rate1_3  ||
                InnerFecRate == (int)DirectShowLib.BDA.BinaryConvolutionCodeRate.Rate2_5  ||
                InnerFecRate == (int)DirectShowLib.BDA.BinaryConvolutionCodeRate.Rate6_7  ||
                InnerFecRate == (int)DirectShowLib.BDA.BinaryConvolutionCodeRate.Rate8_9  ||
                InnerFecRate == (int)DirectShowLib.BDA.BinaryConvolutionCodeRate.Rate9_10
         )  )
        return true;
      else
        return false;

i think that it is all i can check using out Tuning details saved in DB.

 

[mm1352000]

Hi again Vasilich

That looks more complete to me, although most DVB-S2 channels are 8PSK. We store the modulation of DVB-S channels as ModNotSet so it should be safe to treat Mod8psk as the DVB-S2 8 PSK - DVB-S 8 PSK doesn't seem to be very common...

Any further thoughts about DVB-T2?

mm

 

[Wbunaarf]

Any further thoughts about DVB-T2?

The one thing I can see is different between T and T2, according to DVB-T2 - Wikipedia, the free encyclopedia, is the FEC type, but is this information available to MP?

//Johannes

 

[mm1352000]

Hi Johannes

The inner FEC rate is available and needed for satellite tuners. It is not needed for tuning DVB-T or DVB-T2 channels though. The tuner drivers automatically determine the correct FEC rate to use...

mm