Show the year of recording in recorded tv/radio (1 Viewer)

doskabouter

Development Group
  • Team MediaPortal
  • September 27, 2009
    4,583
    2,972
    Nuenen
    Home Country
    Netherlands Netherlands
    @mm1352000

    Pull request made: https://github.com/MediaPortal/MediaPortal-1/pull/107
    Took a bit of time because it wasn't easy to get things compiled (missing serveragent stuff, skipping compilation due to wrong configuration settings in solution etc).
    Couple of questions:
    - I couldn't find a piece of code which is present in the master branch of MP1, and not in the EXP TVE3.5 branch, so I'm not able to fully merge my changes into the TVE3.5 branch.
    it's this piece (in TvRecorded.cs, LoadDirectory method)
    Code:
      if (singleRecording)
      {
        item = BuildItemFromRecording(folder, channels.FirstOrDefault(chan => folder.IdChannel == chan.IdChannel));
        TimeSpan ts = folder.EndTime - folder.StartTime;
        item.Label2 = String.Format("{0} ({1})",
                                 Utils.GetNamedDate(folder.StartTime),
                                 Utils.SecondsToHMString((int)ts.TotalSeconds));
      }

    - I can't imagine that I'm the first one with changes for the TVPlugin, but I didn't see any commits for over 3 years.
    Are other changes in separate branches, and are you going to do a massive merge when the 3.5 version is stable, or am I missing something?

    Paul
     

    regeszter

    Retired Team Member
  • Premium Supporter
  • October 29, 2005
    5,335
    4,954
    Home Country
    Hungary Hungary
    - I can't imagine that I'm the first one with changes for the TVPlugin, but I didn't see any commits for over 3 years.
    Are other changes in separate branches, and are you going to do a massive merge when the 3.5 version is stable, or am I missing something?

    Here is mm's working branch. https://github.com/MediaPortal/MediaPortal-1/commits/EXP-TVE3.5-MP1-MP2_mm_working
    but the master of TVE3.5 is the https://github.com/MediaPortal/MediaPortal-1/tree/EXP-TVE3.5-MP1-MP2
     

    Users who are viewing this thread

    Top Bottom