Reply to thread

Message

<blockquote data-quote="mm1352000" data-source="post: 1258971" data-attributes="member: 82144">Okay. For what it's worth, I think the original code is here:<a href="https://github.com/MediaPortal/MediaPortal-1/tree/Turbosight" target="_blank">MediaPortal/MediaPortal-1</a>If you include my TVE 3.5 working branch, that would make 3 branches with different advantages/disadvantages. Depending on your/team preference, there may be a choice to be made in relation to this. Again, for what it's worth:<ul>
<li data-xf-list-type="ul">FreakyJ<ul>
<li data-xf-list-type="ul">in master (presumably tested)</li>
<li data-xf-list-type="ul">needs at least detection change, CI API function update and CI API DLL</li>
<li data-xf-list-type="ul">a little messy, codewise</li>
</ul></li>
<li data-xf-list-type="ul">Turbosight:<ul>
<li data-xf-list-type="ul">original patch source</li>
<li data-xf-list-type="ul">probably needs a number of functional and compatibility updates (MP and TBS/hardware)</li>
</ul></li>
<li data-xf-list-type="ul">TVE 3.5:<ul>
<li data-xf-list-type="ul">most functionally complete from TBS/hardware perspective</li>
<li data-xf-list-type="ul">needs backporting, testing </li>
</ul></li>
</ul>Mmmm, I'm sorry. It wasn't my intention to suggest or even imply that. As far as I'm aware/concerned, you did a great job merging the best code you could find in tricky circumstances. My comment was simply an expression of surprise at the difference between the code I remember writing and the code I found in master.Yes and yes. We have to be careful to match the version we include with the code we use. There are some subtly different versions of the DLL out there.</blockquote>

[QUOTE="mm1352000, post: 1258971, member: 82144"] Okay. For what it's worth, I think the original code is here: [URL="https://github.com/MediaPortal/MediaPortal-1/tree/Turbosight"]MediaPortal/MediaPortal-1[/URL] If you include my TVE 3.5 working branch, that would make 3 branches with different advantages/disadvantages. Depending on your/team preference, there may be a choice to be made in relation to this. Again, for what it's worth: [LIST] [*]FreakyJ [LIST] [*]in master (presumably tested) [*]needs at least detection change, CI API function update and CI API DLL [*]a little messy, codewise [/LIST] [*]Turbosight: [LIST] [*]original patch source [*]probably needs a number of functional and compatibility updates (MP and TBS/hardware) [/LIST] [*]TVE 3.5: [LIST] [*]most functionally complete from TBS/hardware perspective [*]needs backporting, testing [/LIST] [/LIST] Mmmm, I'm sorry. It wasn't my intention to suggest or even imply that. As far as I'm aware/concerned, you did a [B]great[/B] job merging the best code you could find in tricky circumstances. My comment was simply an expression of surprise at the difference between the code I remember writing and the code I found in master. Yes and yes. We have to be careful to match the version we include with the code we use. There are some subtly different versions of the DLL out there. [/QUOTE]

Verification