Reply to thread

Message: <blockquote data-quote="mm1352000" data-source="post: 894764" data-attributes="member: 82144">Happens to all of us... <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile    :)" loading="lazy" data-shortname=":)" />...although I don't understand: what is it that you think you've fixed that isn't/wasn't working. Nobody has reported anything to me. Reading my post back, I get the distinct impression that I was a bit harsh. Apologies if I came across that way. No need to commit locally. Just let me know if you have tweaks or fixes so we can discuss [briefly] before commit and avoid misunderstandings like the above, and also so that we can ensure that the fix is committed to an active branch and not lost. NBC != correct for DVB-S2 in all cases, even under W7Drivers that are designed to support XP..7 more often than not support signalling with certain modulations.Take TechnoTrend as an example. To signal DVB-S2 to their drivers, you need to pass Mod8Vsb.Even TBS doesn't or didn't used to exclusively support only those modulations to signal DVB-S2. Check the Prof "SDK" --><a href="https://forum.team-mediaportal.com/threads/add-profred-dvb-s2-tuning-parameters.67715/#post-485290" target="_blank">here</a><--. Many of their tuners are or were based on TBS designs and drivers. All of that code does or used to work for at least some TBS tuners. I quote:31 and 32 are the NBC ones, but QPSK and 8PSK are also supported. So my response is that maybe NBC is becoming more standardised than it used to be as time goes on, but:1. "...the [BDA modulations are] more what you'd call "guidelines" than actual rules." (Pirates of the Carribean <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite2" alt=";)" title="Wink    ;)" loading="lazy" data-shortname=";)" />)2. MP and most drivers still support XP, so there are usually mappings in place.3. Older tuners that no longer receive driver updates (eg. Twinhan, TechniSat, TerraTec) do not support the NBC modulations.As such it is not so black and white as NBC is correct and QPSK/8PSK is not. A better solution (which I've already almost finished implementing - another reason to discuss things) would be to move to a BDA-independent set of modulations to:1. Avoid user confusion about which modulations to use for manual scanning, especially for satellite.2. Have more readable and maintainable code.3. Improve compatibility with W7. mm</blockquote>

Verification