There is also BUG in original Mp 1.01 and previous(posted here too to get visibility)

Discussion in 'General Development (no feature request here!)' started by te3hpurp, April 16, 2009.

  1. te3hpurp
    • Premium Supporter

    te3hpurp Retired Team Member

    Joined:
    September 23, 2008
    Messages:
    904
    Likes Received:
    182
    Gender:
    Male
    Occupation:
    Senior Software Architect
    Location:
    Rovaniemi
    Ratings:
    +229 / 0
    Home Country:
    Finland Finland
    Show System Specs
    When using only back button, with no Home button in remote.

    in public static void ActivateWindow(int newWindowId, bool replaceWindow) function
    line 746 in GUIWindowManager.cs



    [...]
    if (_listHistory.Count > 15)
    {
    _listHistory.RemoveAt(0);
    }
    [...]

    If user has no Home button, then after a while using TvGuide user ends up into situation where this
    _listHistory.Count goes over 15. Then Home window gets removed from the _listHistory. It was in position
    0.
    So _listHistory does not contain Home Window anymore.

    Then user starts to pres back button over and over again until 15 times is reached. What happens then:
    You have a function:

    public static void ShowPreviousWindow() in line 914.
    and there is a part:
    [...]
    if (_listHistory.Count == 0)
    {
    return;
    }

    [...]

    So you end up stucked into TvGuide and cannot get into homescreen anymore. Only to start tv by selecting
    channell in guide.

    Well My patch in h**p://forum.team-mediaportal.com/general-development-no-feature-request-here-48/tvguide-navigation-history-54987/ solves these problems, but if MP dev's decide to correct this only, and not touch whole
    history management, then above lines should be something like:


    if (_listHistory.Count == 0)
    {
    //return;
    // if _listhistorycount gets corrupted, go home
    _listHistory.Add((int)GUIWindow.Window.WINDOW_HOME );
    }


    regards,
     
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!