[Approved] Unicode file names for recordings (2 Viewers)

[Vasilich]

as stated by Arion_p, all DShowFilters in MP are compiled as ANSI and thus do not support unicode.
I have problem when i try to record any TV program that has some diacrytics in its name (coming from EPG). Example: "Zoés Zauberschrank".
I also want to record another TV programs that have cyrillic in their names. Example: "Среда обитания".
So setting default codepage for nonunicode programs can't help as the above examples have symbols that cannot be mapped to one codepage.
My patch for TSWriter just adds new function for setting unicode filename for recording, and use this unicode filename later on when recording starts. I left old ANSI function as i don't know what plugins can use it, so old behavior still possible.
Another part of patch forces TVService and TVLibrary to use this new unicode function.
And small change to be able to see these unicode filenames in log file - now TSWriter log is UTF8 -encoded.
I tested all this on my system, and it works.
if you have suggestions how to implement it in better way (except of compiling TSWriter completely with unicode flag) - don't hesitate to discuss it here.

here are some links to threads discussing this problem:
https://forum.team-mediaportal.com/mediaportal-1-1-0-rc-1-2-496/problem-recording-tv-80966/
https://forum.team-mediaportal.com/mediaportal-1-1-0-rc-1-2-496/recorder-unable-create-file-81721/
https://forum.team-mediaportal.com/.../cannot-record-shows-double-byte-names-53580/

 

[god_md5]

is it can help for edit the epg utf-16 grabbing ?
https://forum.team-mediaportal.com/...ext-encoding-dvb-channel-names-epg-etc-66579/

 

[Vasilich]

god_md5, it can help to record the programs even if EPG contains utf-16 symbols, but it is not about decoding unicode EPG entries.

 

[Vasilich]

anyone for submitting/rejecting?

 

[tontsa]

Can you make a patch that doesn't have massive amount of formatting changes so it would be easier to review. Now there's thousands of tabs/space differences all over the place making the patch hard to follow.

 

[Vasilich]

Can you make a patch that doesn't have massive amount of formatting changes so it would be easier to review.

here we are - same patch against latest trunk without any formatting changes

 

[Vasilich]

any chance for this to be reviewed BEFORE MP 1.2.0 release?
or is it hopeless?

 

[infinite.loop]

any chance for this to be reviewed BEFORE MP 1.2.0 release?
or is it hopeless?

Not sure if this will make it into 1.2.0 Alpha which is due next friday.
But I will have a chat with the devs about adding it to 1.2.0.

 

[chemelli]

Spoken with the author and he will partly rework the patch during this weekend.

Simone

 

[Vasilich]

sorry for the delay, but i am still experiencing troubles with hardware on my dev PC.
So here we are with patch for TVLibrary, TSWriter (DVB part) and MPWriter (analogue tuners). (1st post)
Haven't tested analog part as i have only DVB-S, but so far it works fine for me.