Normal
My point here is that doing the coverage of a codebase that has not been written with tests at all (and probably with very poor code coverage) means that you need to commit certain failing tests to show where work needs to be done (argument sanitation is a common example) and the progress done. If it's a new code base it's a different case, but asking for unit tests to all pass assumes you always commit your test at the same time as the code needed for the test to pass, and that's assuming someone that discover a bug and write a test with it would commit the modified code without necessarily knowing what he's doing.Anyway, let's talk about that at a later point, after all i've never contributed back any of my changes from the branching i did on mediaportal so i shouldnt complain about anything at all.
My point here is that doing the coverage of a codebase that has not been written with tests at all (and probably with very poor code coverage) means that you need to commit certain failing tests to show where work needs to be done (argument sanitation is a common example) and the progress done. If it's a new code base it's a different case, but asking for unit tests to all pass assumes you always commit your test at the same time as the code needed for the test to pass, and that's assuming someone that discover a bug and write a test with it would commit the modified code without necessarily knowing what he's doing.
Anyway, let's talk about that at a later point, after all i've never contributed back any of my changes from the branching i did on mediaportal so i shouldnt complain about anything at all.