Reply to thread

Message

<blockquote data-quote="NoMoDo" data-source="post: 4238" data-attributes="member: 10381">Patch uploaded to SourceForge.My patch is up on sourceforge.Note: I will only be available to discuss this patch up until Monday. After that, I will not be able to do any serious MP work for at least six months, and will only be able to come by the chat room on weekends, so please ask me any questions you might have about my patch before Monday.@Frodo: I noticed that in many controls, there is a LOT of difficult-to-maintain duplication when one control is contained within the other (for example, the scrollbar in the listbox, etc etc...). This gets out of hand in FilmStrip, for example. I think that after merging my patch, it should be very easy to fix this. Controls that are contained within controls should be nested elements of the containing control's xml node, and they can each have their own name.For Example:&lt;control&gt;.....&lt;type&gt;thumbnailpanel&lt;/type&gt;.....&lt;main scrollbar&gt;...........&lt;type&gt;vscrollbar&lt;/type&gt;...........etc.......&lt;/main scrollbar&gt;....&lt;default thumbnail&gt;...........&lt;type&gt;image&lt;/type&gt;etc...And the corresponding C# code would simply be:[XmlSkinElement(&quot;main scollbar&quot;)] GUIvscrollBar m_scrollBar;[XmlSkinElement(&quot;default thumbnail) GUIImage&nbsp; m_defaultThumbnail;I think this will remove a few good dozens (more than a 100?) lines of needless duplication. And again, with my patch this should be extremely simple to introduce elegantly, but I'm not going to do this myself as I've tapped out on time I can spend on MP for a while (life gets in the way&nbsp; <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite8" alt=":D" title="Big Grin&nbsp; &nbsp; :D" loading="lazy" data-shortname=":D" /> )</blockquote>

[QUOTE="NoMoDo, post: 4238, member: 10381"] [b]Patch uploaded to SourceForge.[/b] My patch is up on sourceforge. [b]Note:[/b] I will only be available to discuss this patch up until Monday. After that, I will not be able to do any serious MP work for at least six months, and will only be able to come by the chat room on weekends, so please ask me any questions you might have about my patch before Monday. [b]@Frodo[/b]: I noticed that in many controls, there is a LOT of difficult-to-maintain duplication when one control is contained within the other (for example, the scrollbar in the listbox, etc etc...). This gets out of hand in FilmStrip, for example. I think that after merging my patch, it should be very easy to fix this. Controls that are contained within controls should be nested elements of the containing control's xml node, and they can each have their own name. For Example: <control> .....<type>thumbnailpanel</type> .....<main scrollbar> ...........<type>vscrollbar</type> ...........etc... ....</main scrollbar> ....<default thumbnail> ...........<type>image</type> etc... And the corresponding C# code would simply be: [XmlSkinElement("main scollbar")] GUIvscrollBar m_scrollBar; [XmlSkinElement("default thumbnail) GUIImage m_defaultThumbnail; I think this will remove a few good dozens (more than a 100?) lines of needless duplication. And again, with my patch this should be extremely simple to introduce elegantly, but I'm not going to do this myself as I've tapped out on time I can spend on MP for a while (life gets in the way :D ) [/QUOTE]

Verification