Reply to thread

Message

<blockquote data-quote="morfius" data-source="post: 1098805" data-attributes="member: 116650">Finally, I decided to rewrite the entire procedure. You can test with this simple program.[code]#region usingusing System;using System.Diagnostics;using System.Net;using System.IO;using System.Threading;using MediaPortal.GUI.Library;//add ref Core &amp; Utils#endregion using/*&nbsp;* Developper:&nbsp; &nbsp; &nbsp; mOrfiUs&nbsp;* e-mail:&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; apifilmaffinityimdb@gmail.com&nbsp;* web:&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; https://sourceforge.net/projects/apifilmaffinityimdb/&nbsp;* Forum post:&nbsp; &nbsp; &nbsp; https://forum.team-mediaportal.com/posts/1098788&nbsp;* Description:&nbsp; &nbsp;&nbsp; New Core/Util/utils.cs DownLoadImage procedure&nbsp;* FIX:&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; Set the necessary headers for proper WebRequest (ex. filmaffinity)&nbsp;* Date&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; 2014/09/06&nbsp;*/namespace TestDLImage{&nbsp; &nbsp; class TestDLImage&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; static void Main(string[] args)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; string[] lDownLoadImages = new string[] {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &quot;http://fr.web.img2.acsta.net/r_640_600/b_1_d6d6d6/pictures/14/07/04/14/59/301675.jpg&quot;, &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &quot;http://fr.web.img5.acsta.net/r_160_240/b_1_d6d6d6/pictures/14/07/04/14/59/301675.jpg&quot;, &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &quot;http://st.kinopoisk.ru/images/film_original/450237.jpg&quot;, &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &quot;http://image.tmdb.org/t/p/w396/1APNYPrWaZxZnBqnsHTou2MaHnx.jpg&quot;, &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &quot;http://pic.filmaffinity.com/Monuments_Men-681632116-large.jpg&quot;, &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &quot;http://pics.filmaffinity.com/Monuments_Men-681632116-large.jpg&quot;, &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &quot;http://pics.filmaffinity.com/nts_Men-682116-large.jpg&quot;, &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &quot;http://ia.media-imdb.com/images/M/MV5BMTQ5NTg5ODk4OV5BMl5BanBnXkFtZTgwODc4MTMzMDE@._V1__SX300.jpg&quot;, &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &quot;http://ia.media-imdb.com/images/M/MV5BDk4OV5BMl5BanBnXkFtZTgwODc4MTMzMDE@&quot;, &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &quot;http://ia.media-imdb.com/images/M/MV5BMjM4MjU3MDgzNV5BMl5BanBnXkFtZTgwODE3NzcwMTE@&quot;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; };&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; int iCount = 0;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; foreach (string DLImage in lDownLoadImages)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; DownLoadImage(DLImage, @&quot;c:\temp&quot; + iCount++.ToString(&quot;000&quot;) + &quot;.jpg&quot;);&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; /// &lt;summary&gt;&nbsp; &nbsp; &nbsp; &nbsp; /// Download a remote image and save it locally.&nbsp; &nbsp; &nbsp; &nbsp; /// If it fails the first time, wait one second and try to download again.&nbsp; &nbsp; &nbsp; &nbsp; /// UserAgent and Accept headers are set for correct request.&nbsp; &nbsp; &nbsp; &nbsp; /// Unfortunately, synchronous downloads are often problematic, so it is necessary to correctly handle errors.&nbsp; &nbsp; &nbsp; &nbsp; /// &lt;/summary&gt;&nbsp; &nbsp; &nbsp; &nbsp; /// &lt;param name=&quot;strURL&quot;&gt;remote image to download&lt;/param&gt;&nbsp; &nbsp; &nbsp; &nbsp; /// &lt;param name=&quot;strFile&quot;&gt;local image to save&lt;/param&gt;&nbsp; &nbsp; &nbsp; &nbsp; /// &lt;param name=&quot;secondTry&quot;&gt;bool used for the recursive call, after first fail&lt;/param&gt;&nbsp; &nbsp; &nbsp; &nbsp; public static void DownLoadImage(string strURL, string strFile, bool secondTry = false)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (string.IsNullOrEmpty(strURL) || string.IsNullOrEmpty(strFile))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Uri uri = new Uri(strURL);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; HttpWebRequest wReq = (HttpWebRequest)WebRequest.Create(uri);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; wReq.Proxy.Credentials = CredentialCache.DefaultCredentials;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; wReq.UserAgent = &quot;Mozilla/8.0 (compatible; MSIE 9.0; Windows NT 6.1; .NET CLR 1.0.3705;)&quot;;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; wReq.Accept = &quot;*/*&quot;;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; //should check the results before continue&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; //if wr.StatusCode == HttpStatusCode.OK&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; //but don't have reason if is a void procedure&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; try&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; using (HttpWebResponse wr = (HttpWebResponse)wReq.GetResponse())&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; using (BinaryReader br = new BinaryReader(wr.GetResponseStream()))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; using (FileStream fs = new FileStream(strFile, FileMode.OpenOrCreate, FileAccess.Write))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; byte[] b = new byte[1024 * 128];//Should we increase the buffer size?. We live in 2014&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; int bRead;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; do&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; bRead = br.Read(b, 0, b.Length);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; fs.Write(b, 0, bRead);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; } while (bRead != 0);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; catch (System.Net.WebException eWebException)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Log.Info(&quot;Utils: DownLoadImage {1} failed: {0}&quot;, eWebException.Message + (secondTry ? &quot; second try also fail&quot; : string.Empty), strURL);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; //after second fail, return&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (secondTry)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; //just wait a second, and then try again&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Thread.Sleep(1000);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; DownLoadImage(strURL, strFile, true);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return;&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; }}[/code]Greetings from Spain!!!</blockquote>

[QUOTE="morfius, post: 1098805, member: 116650"] Finally, I decided to rewrite the entire procedure. You can test with this simple program. [code] #region using using System; using System.Diagnostics; using System.Net; using System.IO; using System.Threading; using MediaPortal.GUI.Library;//add ref Core & Utils #endregion using /* * Developper: mOrfiUs * e-mail: apifilmaffinityimdb@gmail.com * web: https://sourceforge.net/projects/apifilmaffinityimdb/ * Forum post: https://forum.team-mediaportal.com/posts/1098788 * Description: New Core/Util/utils.cs DownLoadImage procedure * FIX: Set the necessary headers for proper WebRequest (ex. filmaffinity) * Date 2014/09/06 */ namespace TestDLImage { class TestDLImage { static void Main(string[] args) { string[] lDownLoadImages = new string[] { "http://fr.web.img2.acsta.net/r_640_600/b_1_d6d6d6/pictures/14/07/04/14/59/301675.jpg", "http://fr.web.img5.acsta.net/r_160_240/b_1_d6d6d6/pictures/14/07/04/14/59/301675.jpg", "http://st.kinopoisk.ru/images/film_original/450237.jpg", "http://image.tmdb.org/t/p/w396/1APNYPrWaZxZnBqnsHTou2MaHnx.jpg", "http://pic.filmaffinity.com/Monuments_Men-681632116-large.jpg", "http://pics.filmaffinity.com/Monuments_Men-681632116-large.jpg", "http://pics.filmaffinity.com/nts_Men-682116-large.jpg", "http://ia.media-imdb.com/images/M/MV5BMTQ5NTg5ODk4OV5BMl5BanBnXkFtZTgwODc4MTMzMDE@._V1__SX300.jpg", "http://ia.media-imdb.com/images/M/MV5BDk4OV5BMl5BanBnXkFtZTgwODc4MTMzMDE@", "http://ia.media-imdb.com/images/M/MV5BMjM4MjU3MDgzNV5BMl5BanBnXkFtZTgwODE3NzcwMTE@" }; int iCount = 0; foreach (string DLImage in lDownLoadImages) DownLoadImage(DLImage, @"c:\temp" + iCount++.ToString("000") + ".jpg"); } /// <summary> /// Download a remote image and save it locally. /// If it fails the first time, wait one second and try to download again. /// UserAgent and Accept headers are set for correct request. /// Unfortunately, synchronous downloads are often problematic, so it is necessary to correctly handle errors. /// </summary> /// <param name="strURL">remote image to download</param> /// <param name="strFile">local image to save</param> /// <param name="secondTry">bool used for the recursive call, after first fail</param> public static void DownLoadImage(string strURL, string strFile, bool secondTry = false) { if (string.IsNullOrEmpty(strURL) || string.IsNullOrEmpty(strFile)) return; Uri uri = new Uri(strURL); HttpWebRequest wReq = (HttpWebRequest)WebRequest.Create(uri); wReq.Proxy.Credentials = CredentialCache.DefaultCredentials; wReq.UserAgent = "Mozilla/8.0 (compatible; MSIE 9.0; Windows NT 6.1; .NET CLR 1.0.3705;)"; wReq.Accept = "*/*"; //should check the results before continue //if wr.StatusCode == HttpStatusCode.OK //but don't have reason if is a void procedure try { using (HttpWebResponse wr = (HttpWebResponse)wReq.GetResponse()) using (BinaryReader br = new BinaryReader(wr.GetResponseStream())) using (FileStream fs = new FileStream(strFile, FileMode.OpenOrCreate, FileAccess.Write)) { byte[] b = new byte[1024 * 128];//Should we increase the buffer size?. We live in 2014 int bRead; do { bRead = br.Read(b, 0, b.Length); fs.Write(b, 0, bRead); } while (bRead != 0); } } catch (System.Net.WebException eWebException) { Log.Info("Utils: DownLoadImage {1} failed: {0}", eWebException.Message + (secondTry ? " second try also fail" : string.Empty), strURL); //after second fail, return if (secondTry) return; //just wait a second, and then try again Thread.Sleep(1000); DownLoadImage(strURL, strFile, true); } return; } } } [/code] Greetings from Spain!!! [/QUOTE]

Verification