Video scan doesn't seem to recognize IMDB number (2 Viewers)

[ajs]

I cloned the repo and went to build the test projects. It did not build without a nuget.config change. That was problem no. 1. I can give you screenshots to prove it.

I did the same thing. I didn't change anything in the configuration. Everything built successfully on the first try. It also builds without any issues in GitHub Actions and AppVeyour whenever there's a change in the repository. So it looks like there's no problem.

After that, visual studio was not able to run the tests.

As I mentioned earlier, we don’t use them because they’re pointless — they don’t even cover 30% of the functionality. And we don’t have anyone who can provide 100% coverage. That’s why we rely on functional testing by actual users.

is that a joke?

No, I'm not joking—the tests were written for a version that's at least 10 years old, and a lot has changed since then. That's why the tests don't work. And they're disabled in all CI environments during automated builds.

Searching the repo for "yml" brings up no relevant results. I don't see any build definition.

MediaPortal-1/.github/workflows at master · MediaPortal/MediaPortal-1

Home Theater and Digital Video Recording solution for Windows. - MediaPortal/MediaPortal-1

github.com

AppVeyor

ci.appveyor.com

Is that in source control?

MediaPortal Wiki

Our new Wiki offers 5511 pages on how to install, setup, use, customize and contribute to MediaPortal.

www.team-mediaportal.com

Of the 12 scripts, only TI_MDB is close to getting data successfully

Because I've been correcting it constantly for years
I'm tired of fixing other scrapers; IMDb changes its markup several times a year, and sometimes even several times a month, so scrapers (regular expressions) are a dead end. Every time IMDb changes its markup, they'll stop working.

in the tests in my draft PR

We have a grabber test, but it's pointless. That's because a grabber might work at the time of release, but it might not work the next day.

MediaPortal-1/.github/workflows/workflow_grabber_test.yml at master · MediaPortal/MediaPortal-1

Home Theater and Digital Video Recording solution for Windows. - MediaPortal/MediaPortal-1

github.com

 

[ajs]

PS: @CSMR We have a rule.

One issue/change – One Jira ticket – One branch with the ticket number – One PR.

 

[doskabouter]

My thoughts:
Indeed the tests are a leftover from long ago and have no real value anymore.
As for things that depend on external sources (imdbscripts, subtitledownloader,onlinevideos etc): that is always a struggle to keep everything (even if you only update those you actually use yourself) working. We do try to find the most stable source ofcourse but sometimes you just don't have that and have to fall back to html parsing, however fragile this is.

Having tests that test if those are working is at best a single-point-in-time check which will not say anything for the future.
That is why we want to be able to distribute updates without doing a full reinstall/update of the mediaportal setup.

But if you think its easier for you to fix the tests in a TDD kind of style (working through a failed test) you're free to do so ofcourse