home
products
contribute
download
documentation
forum
Home
Forums
New posts
Search forums
What's new
New posts
All posts
Latest activity
Members
Registered members
Current visitors
Donate
Log in
Register
What's new
Search
Search
Search titles only
By:
New posts
Search forums
Search titles only
By:
Menu
Log in
Register
Navigation
Install the app
Install
More options
Contact us
Close Menu
Forums
MediaPortal 1
MediaPortal 1 Plugins
Video scan doesn't seem to recognize IMDB number
Contact us
RSS
JavaScript is disabled. For a better experience, please enable JavaScript in your browser before proceeding.
You are using an out of date browser. It may not display this or other websites correctly.
You should upgrade or use an
alternative browser
.
Reply to thread
Message
<blockquote data-quote="CSMR" data-source="post: 1305137" data-attributes="member: 112199"><p>The repo is not in good shape but I'll try for minimal change to get things to work without doing massive cleanup at this point.</p><p>I was able to get the test project to build via a nuget.config change.</p><p>The test projects didn't run and I found they had nunit dlls checked into the repo! So updated to nunit 3 so now they run (but often fail) in VS.</p><p></p><p>Ideally there would be:</p><ul> <li data-xf-list-type="ul">an automated yml build and run of test projects in github</li> <li data-xf-list-type="ul">consistency of handling of video title formats between title formats confirmed by tests</li> <li data-xf-list-type="ul">an md file explaining this format and deployed to the website</li> <li data-xf-list-type="ul">removed need for individual scripts to parse title formats, with this being done centrally and the script interface modified</li> <li data-xf-list-type="ul">replacement of .csscript files with .cs files to get intellisense on them, centralize creation of these files, remove the need for interpreters</li> </ul><p></p><p>For my PR I'll just include:</p><ul> <li data-xf-list-type="ul">fix the nuget.config file</li> <li data-xf-list-type="ul">update nunit so that the tests can be run (with many existing ones failing)</li> <li data-xf-list-type="ul">make a small md file documenting the format based on the consolidated regexes across the various script files</li> <li data-xf-list-type="ul">add tests checking this format and checking that data is retrieved from imdb/tmdb, fixing the failing scripts</li> </ul><p></p><p>For me these script files have failed many many times over the years so after this is done my life is going to get better, at least when the next mediaportal version is released. I hope that's the same for others too.</p><p></p><p>[USER=68833]@ajs[/USER] can someone enable github issues?</p></blockquote><p></p>
[QUOTE="CSMR, post: 1305137, member: 112199"] The repo is not in good shape but I'll try for minimal change to get things to work without doing massive cleanup at this point. I was able to get the test project to build via a nuget.config change. The test projects didn't run and I found they had nunit dlls checked into the repo! So updated to nunit 3 so now they run (but often fail) in VS. Ideally there would be: [LIST] [*]an automated yml build and run of test projects in github [*]consistency of handling of video title formats between title formats confirmed by tests [*]an md file explaining this format and deployed to the website [*]removed need for individual scripts to parse title formats, with this being done centrally and the script interface modified [*]replacement of .csscript files with .cs files to get intellisense on them, centralize creation of these files, remove the need for interpreters [/LIST] For my PR I'll just include: [LIST] [*]fix the nuget.config file [*]update nunit so that the tests can be run (with many existing ones failing) [*]make a small md file documenting the format based on the consolidated regexes across the various script files [*]add tests checking this format and checking that data is retrieved from imdb/tmdb, fixing the failing scripts [/LIST] For me these script files have failed many many times over the years so after this is done my life is going to get better, at least when the next mediaportal version is released. I hope that's the same for others too. [USER=68833]@ajs[/USER] can someone enable github issues? [/QUOTE]
Insert quotes…
Verification
Post reply
Forums
MediaPortal 1
MediaPortal 1 Plugins
Video scan doesn't seem to recognize IMDB number
Contact us
RSS
Top
Bottom