Reply to thread

Message

<blockquote data-quote="CSMR" data-source="post: 1305146" data-attributes="member: 112199">OK. It sounds from your reply that some of the dev team is committed to maintaining the repo in a non-working state based on the fact it's been like that for decades. That's a shame because mediaportal cannot progress if so.The problems were:<ul>
<li data-xf-list-type="ul">I cloned the repo and went to build the test projects. It did not build without a nuget.config change. That was problem no. 1. I can give you screenshots to prove it.</li>
<li data-xf-list-type="ul">After that, visual studio was not able to run the tests. The tests had a copy of nunit as a dll. mediaportal/MediaPortal.Tests/nunit.framework.dll That's &quot;working fine&quot;? Updating to nuget 3 fixed that and I was able to delete the dll.</li>
<li data-xf-list-type="ul">After getting tests to run, they fail. Who cares because you &quot;don't see the point in tests&quot;... is that a joke?</li>
</ul>Searching the repo for &quot;yml&quot; brings up no relevant results. I don't see any build definition.Is that in source control? A code search brings up nothing. I assume it's there but not in the repo. That's not ideal but is manageable - someone with access just needs to make the change once the definition is clear.In theory I understand your point, but this wonderful flexible system of scripts is completely broken. Of the 12 scripts, only TI_MDB is close to getting data successfully, in the tests in my draft PR <a href="https://github.com/MediaPortal/MediaPortal-1/pull/458/changes" target="_blank">Add grabber script tests and get some working by charlesroddie · Pull Request #458 · MediaPortal/MediaPortal-1</a> .</blockquote>

[QUOTE="CSMR, post: 1305146, member: 112199"] OK. It sounds from your reply that some of the dev team is committed to maintaining the repo in a non-working state based on the fact it's been like that for decades. That's a shame because mediaportal cannot progress if so. The problems were: [LIST] [*]I cloned the repo and went to build the test projects. It did not build without a nuget.config change. That was problem no. 1. I can give you screenshots to prove it. [*]After that, visual studio was not able to run the tests. The tests had a copy of nunit as a dll. mediaportal/MediaPortal.Tests/nunit.framework.dll That's "working fine"? Updating to nuget 3 fixed that and I was able to delete the dll. [*]After getting tests to run, they fail. Who cares because you "don't see the point in tests"... is that a joke? [/LIST] Searching the repo for "yml" brings up no relevant results. I don't see any build definition. Is that in source control? A code search brings up nothing. I assume it's there but not in the repo. That's not ideal but is manageable - someone with access just needs to make the change once the definition is clear. In theory I understand your point, but this wonderful flexible system of scripts is completely broken. Of the 12 scripts, only TI_MDB is close to getting data successfully, in the tests in my draft PR [URL='https://github.com/MediaPortal/MediaPortal-1/pull/458/changes']Add grabber script tests and get some working by charlesroddie · Pull Request #458 · MediaPortal/MediaPortal-1[/URL] . [/QUOTE]

Verification