Reply to thread

Message

<blockquote data-quote="ajs" data-source="post: 1305149" data-attributes="member: 68833">I did the same thing. I didn't change anything in the configuration. Everything built successfully on the first try. It also builds without any issues in GitHub Actions and AppVeyour whenever there's a change in the repository. So it looks like there's no problem.As I mentioned earlier, we don’t use them because they’re pointless — they don’t even cover 30% of the functionality. And we don’t have anyone who can provide 100% coverage. That’s why we rely on functional testing by actual users.No, I'm not joking—the tests were written for a version that's at least 10 years old, and a lot has changed since then. That's why the tests don't work. And they're disabled in all CI environments during automated builds.[URL unfurl=&quot;true&quot;]https://github.com/MediaPortal/MediaPortal-1/tree/master/.github/workflows[/URL][URL unfurl=&quot;true&quot;]https://ci.appveyor.com/project/MediaPortal/mediaportal-1/history[/URL][URL unfurl=&quot;true&quot;]https://www.team-mediaportal.com/wiki/[/URL]Because I've been correcting it constantly for years <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile&nbsp; &nbsp; :)" loading="lazy" data-shortname=":)" />I'm tired of fixing other scrapers; IMDb changes its markup several times a year, and sometimes even several times a month, so scrapers (regular expressions) are a dead end. Every time IMDb changes its markup, they'll stop working.We have a grabber test, but it's pointless. That's because a grabber might work at the time of release, but it might not work the next day.[URL unfurl=&quot;true&quot;]https://github.com/MediaPortal/MediaPortal-1/blob/master/.github/workflows/workflow_grabber_test.yml[/URL]</blockquote>

[QUOTE="ajs, post: 1305149, member: 68833"] I did the same thing. I didn't change anything in the configuration. Everything built successfully on the first try. It also builds without any issues in GitHub Actions and AppVeyour whenever there's a change in the repository. So it looks like there's no problem. As I mentioned earlier, we don’t use them because they’re pointless — they don’t even cover 30% of the functionality. And we don’t have anyone who can provide 100% coverage. That’s why we rely on functional testing by actual users. No, I'm not joking—the tests were written for a version that's at least 10 years old, and a lot has changed since then. That's why the tests don't work. And they're disabled in all CI environments during automated builds. [URL unfurl="true"]https://github.com/MediaPortal/MediaPortal-1/tree/master/.github/workflows[/URL] [URL unfurl="true"]https://ci.appveyor.com/project/MediaPortal/mediaportal-1/history[/URL] [URL unfurl="true"]https://www.team-mediaportal.com/wiki/[/URL] Because I've been correcting it constantly for years :) I'm tired of fixing other scrapers; IMDb changes its markup several times a year, and sometimes even several times a month, so scrapers (regular expressions) are a dead end. Every time IMDb changes its markup, they'll stop working. We have a grabber test, but it's pointless. That's because a grabber might work at the time of release, but it might not work the next day. [URL unfurl="true"]https://github.com/MediaPortal/MediaPortal-1/blob/master/.github/workflows/workflow_grabber_test.yml[/URL] [/QUOTE]

Verification