Reply to thread

I'm finding the odd what-I-think-is-a-bug. Do you want me to let you know about them?


For example, in GUIVideoFiles.cs, method DoOnPlayBackStoppedOrChanged(), a movie has been watch and we know this for sure,


But the code does this:

[CODE=csharp]

            if (!watched)

            {

              VideoDatabase.SetMovieWatchedStatus(idMovie, false, playTimePercentage);

            }

            else // Update new percentage if already watched

            {

              VideoDatabase.SetMovieWatchedStatus(idMovie, true, playTimePercentage);

            }

[/CODE]

Now, watched has just been read from the database. Therefore, when this is the first time you have watched this movie the watched status will be False and won't get changed - and it never does. I've changed the code to this:



              //  This method is only called when movie is watched, so set watched to true

              //  irrespective of whether the movie had been watched before.



I should point out that the earlier code does this


          //Set file "watched" only if  user % value or higher played time (share view)


but this isn't correct when this is the first time you have watched the movie because the _watchedPercentage isn't being set correctly (it seems to be hard coded at 95).


Hope this helps.


Tony


Top Bottom