home
products
contribute
download
documentation
forum
Home
Forums
New posts
Search forums
What's new
New posts
All posts
Latest activity
Members
Registered members
Current visitors
Donate
Log in
Register
What's new
Search
Search
Search titles only
By:
New posts
Search forums
Search titles only
By:
Menu
Log in
Register
Navigation
Install the app
Install
More options
Contact us
Close Menu
Forums
MediaPortal 1
Development
Improvement Suggestions
VideoDatabaseV5 design issue
Contact us
RSS
JavaScript is disabled. For a better experience, please enable JavaScript in your browser before proceeding.
You are using an out of date browser. It may not display this or other websites correctly.
You should upgrade or use an
alternative browser
.
Reply to thread
Message
<blockquote data-quote="Anthony Vaughan" data-source="post: 1285459" data-attributes="member: 153283"><p>I'm finding the odd what-I-think-is-a-bug. Do you want me to let you know about them?</p><p></p><p>For example, in GUIVideoFiles.cs, method DoOnPlayBackStoppedOrChanged(), a movie has been watch and we know this for sure,</p><p></p><p>But the code does this:</p><p>[CODE=csharp]</p><p> if (!watched)</p><p> {</p><p> VideoDatabase.SetMovieWatchedStatus(idMovie, false, playTimePercentage);</p><p> }</p><p> else // Update new percentage if already watched</p><p> {</p><p> VideoDatabase.SetMovieWatchedStatus(idMovie, true, playTimePercentage);</p><p> }</p><p>[/CODE]</p><p>Now, watched has just been read from the database. Therefore, when this is the first time you have watched this movie the watched status will be False and won't get changed - and it never does. I've changed the code to this:</p><p></p><p></p><p> // This method is only called when movie is watched, so set watched to true</p><p> // irrespective of whether the movie had been watched before.</p><p></p><p></p><p>I should point out that the earlier code does this</p><p></p><p> //Set file "watched" only if user % value or higher played time (share view)</p><p></p><p>but this isn't correct when this is the first time you have watched the movie because the _watchedPercentage isn't being set correctly (it seems to be hard coded at 95).</p><p></p><p>Hope this helps.</p><p></p><p>Tony</p></blockquote><p></p>
[QUOTE="Anthony Vaughan, post: 1285459, member: 153283"] I'm finding the odd what-I-think-is-a-bug. Do you want me to let you know about them? For example, in GUIVideoFiles.cs, method DoOnPlayBackStoppedOrChanged(), a movie has been watch and we know this for sure, But the code does this: [CODE=csharp] if (!watched) { VideoDatabase.SetMovieWatchedStatus(idMovie, false, playTimePercentage); } else // Update new percentage if already watched { VideoDatabase.SetMovieWatchedStatus(idMovie, true, playTimePercentage); } [/CODE] Now, watched has just been read from the database. Therefore, when this is the first time you have watched this movie the watched status will be False and won't get changed - and it never does. I've changed the code to this: // This method is only called when movie is watched, so set watched to true // irrespective of whether the movie had been watched before. I should point out that the earlier code does this //Set file "watched" only if user % value or higher played time (share view) but this isn't correct when this is the first time you have watched the movie because the _watchedPercentage isn't being set correctly (it seems to be hard coded at 95). Hope this helps. Tony [/QUOTE]
Insert quotes…
Verification
Post reply
Forums
MediaPortal 1
Development
Improvement Suggestions
VideoDatabaseV5 design issue
Contact us
RSS
Top
Bottom