Reply to thread

Message

<blockquote data-quote="joboehl" data-source="post: 74648" data-attributes="member: 23490">Hi, I was thinking in making the volume OSD available troughout the whole MP experience, but after taking a look at the source code I got a doubt. I see that the VolumeHandler sends the message ACTION_SHOW_VOLUME and this message is then treated inside each module (Eg: WINDOSW_TVFULLSCREEN or WINDOWS_FULLSCREEN_VIDEO). I don't think it would be practical to code a volumebar renderer in each screen where it could be used, si I tough about moving the ACTION_SHOW_VOLUME to the main WindowsManager (GUIWindowsManager.cs). The point is, I don't know if this (making it specific for each component) was make on purpose or not. If it was, I can then start coding inside each module (musics, menus, etc) the volumear handler. If not, I tough about this approach initially. - Split the RenderVolume/Render loginc into a separate module/file. - Move the ACTION_SHOW_VOLUME message handling to the main GUIWindowManager. - Always direct, indepedent of the screen, to the volume handler functions and decided in there what's needed to do in terms of rendering. I was also thinking about some improvements so skins could work a little bit more in terms of the look and feel of the volumebar, but maybe in the future. Since I'am realy new to this project, I don't want to break any structure you guys are defining, so would like to understand where should I put this functions if I decided for the wrong places. Also, if anyone is already looking at this, I'll step back or help. Up to you guys. <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile&nbsp; &nbsp; :)" loading="lazy" data-shortname=":)" />Comments anyone?Thanks, Julio</blockquote>

[QUOTE="joboehl, post: 74648, member: 23490"] Hi, I was thinking in making the volume OSD available troughout the whole MP experience, but after taking a look at the source code I got a doubt. I see that the VolumeHandler sends the message ACTION_SHOW_VOLUME and this message is then treated inside each module (Eg: WINDOSW_TVFULLSCREEN or WINDOWS_FULLSCREEN_VIDEO). I don't think it would be practical to code a volumebar renderer in each screen where it could be used, si I tough about moving the ACTION_SHOW_VOLUME to the main WindowsManager (GUIWindowsManager.cs). The point is, I don't know if this (making it specific for each component) was make on purpose or not. If it was, I can then start coding inside each module (musics, menus, etc) the volumear handler. If not, I tough about this approach initially. - Split the RenderVolume/Render loginc into a separate module/file. - Move the ACTION_SHOW_VOLUME message handling to the main GUIWindowManager. - Always direct, indepedent of the screen, to the volume handler functions and decided in there what's needed to do in terms of rendering. I was also thinking about some improvements so skins could work a little bit more in terms of the look and feel of the volumebar, but maybe in the future. Since I'am realy new to this project, I don't want to break any structure you guys are defining, so would like to understand where should I put this functions if I decided for the wrong places. Also, if anyone is already looking at this, I'll step back or help. Up to you guys. :) Comments anyone? Thanks, Julio [/QUOTE]

Verification