YAC Caller ID Enhancements (1 Viewer)

[dabbith]

Hello,

I would like to enhance the YAC Caller ID plugin. I just have a few protocol questions first. I would like to add the same Outlook lookup and media pausing that the ISDN caller ID plugin has. Here are my questions:

The OutlookHelper class under the ISDN plugin isn't specific to ISDN and could be used for YAC also. To use this class with the YAC plugin, should I:
a) Just use it
b) Add a comment to the class that it's being called from a plugin in another directory
c) Copy the class into the YAC plugin directory (I assume this one is wrong)
d) Suggest the file be moved up to the CallerId folder, parent of both YAC and ISDN

I don't want to call OutlookHelper and not have the next developer realize it's used outside of ISDN.

I have a similar issue with ISDNSetupForm.cs, with very minor modifications (replace ISDN in the title and change where it stores the config files), it could be used for YAC. Of course the name would no longer really be valid.

Also, one uses GUIDialogNotify and one uses GUIMessage, can someone give me a hint on which should be used when? Looks like I'd have to make YAC use GUIDialogNotify to get the timeout to work.

Thanks,

Dan

 

[mzemina]

Dan - I hope you are able to get an answer. I think your mods would be well worth it!

 

[dabbith]

Well,
Since I didn't get any answers I went ahead and guessed. I just reused the OutlookHelper and copied and modified the setup form. Now my question is how should I post the changes? Some of what I changed was simple bug fixes to the existing code, some of it is enhancements. Should I post them as one patch, or should I post the bug fixes separately from the enhancements?

 

[mzemina]

Maybe you should get on the IRC chat and ask the developers there?

 

[dabbith]

I've submitted my patches to the project. If anyone would like to test these changes let me know and I can provide a binary.

 

[dabbith]

I've uploaded a binary based on the 10/11 ProcessPlugin SVN sources. You can download it here if you'd like to test, but please make sure you are running the 10/11 SVN build. The source used to build this can be located in the patch queue for MediaPortal. If someone would like a build based on the RC1 or release builds please let me know.

http://danielarnold.net/MediaPortal/ProcessPlugins.zip

 

[providers]

Hi,

I tryed with the MediaPortal SVN-Snapshot: 10-11-2007 16-49h - Revision:16181
And it dosent work...

I can enable and configure the new YAC plugin, but when my phone rings, no messages is popping up


The original ProcessPlugin.dll works with out any problems.


Rgs.
Providers

 

[dabbith]

Can you send me your mediaportal.log file? Also, can you re-download the file and try again, I've added in some more debug logging messages. When you test, try using the "Test Listeners" test call as well as a real call (it's on the listeners dialog on the YAC server). Also, are you running the YAC server on the same PC as MediaPortal or a different PC?

Thx

 

[krl69]

Does YAC support ISDN modem/cards?

KRL

 

[dabbith]

YAC may support your ISDN modem, it would depend if you ISDN card is TAPI compliant.

On the other hand, MediaPortal already has an ISDN Caller ID plug-in built in. It's named "ISDN Caller-ID" and should be part of the default install. It already had Outlook lookup and media pausing. It's actually where I got most of the code I used for the YAC plugin. I did fix a few bugs in it while I was working on the YAC code, but it should work pretty well out of the box. IIRC, the bugs were that it ignored the setting about resuming on timeout and didn't always get the pictures from Outlook correctly.

I think the ISDN plug-in has better international support for determining the location of the call.