Reply to thread

Message

<blockquote data-quote="ojo" data-source="post: 3180" data-attributes="member: 10402">I did some profiling using the newly released version of NProf (0.0.9) check <a href="http://nprof.sourceforge.net" target="_blank">http://nprof.sourceforge.net</a> (they seem to have some problems updating the sourceforge pages, so you will have to check this page for the newest download <a href="http://sourceforge.net/project/showfiles.php?group_id=74129" target="_blank">http://sourceforge.net/project/showfiles.php?group_id=74129</a>)I found out that in the &quot;main thread&quot; 28% of the processing were done inside AMS.Profile.GetXmlDocument. 59 times the method was called and everytime the document was re-read, reparsed by the System.XML validator and populated into a XmlDocument object.So i did some thinking. Why not read it once and just &quot;cache&quot; it. I realize this is not the final solution, since you will have to make even further changes to make sure the save method works correctly and maybe implement a FileWatcher to get it right. But it is &quot;prove of concept&quot; for the Singleton idear.I made an new Class called SingletonXmlHolder. This class ensures that it only initializes once and reads the XML document once. Then I changed a bit in the GetXmlDocument() method and the result (drumrolls......) 0,15% of the processing time. [code]namespace AMS.Profile{&nbsp; class SingletonXmlHolder&nbsp; {&nbsp; &nbsp; private static SingletonXmlHolder instance;&nbsp; &nbsp; private static System.Xml.XmlDocument _XmlDocument = new System.Xml.XmlDocument();&nbsp; &nbsp; private SingletonXmlHolder()&nbsp; &nbsp; {&nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; public static SingletonXmlHolder GetInstance(string m_strFileName)&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; if(instance == null)&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; instance = new SingletonXmlHolder();&nbsp; &nbsp; &nbsp; &nbsp; _XmlDocument.Load(m_strFileName);&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; return instance;&nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; public System.Xml.XmlDocument XmlDocument&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; get { return _XmlDocument; }&nbsp; &nbsp; }&nbsp; }&nbsp; &nbsp; public class Xml :IDisposable&nbsp; {&nbsp; &nbsp; // Fields&nbsp; &nbsp; private string m_rootName = &quot;profile&quot;;.....&nbsp; &nbsp; private XmlDocument GetXmlDocument()&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; // Check kept for the moment but should be moved to SingletonXmlHolder&nbsp; &nbsp; &nbsp; if (!File.Exists(m_strFileName))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; return null;&nbsp; &nbsp; &nbsp; SingletonXmlHolder snglXmlHolder = SingletonXmlHolder.GetInstance(m_strFileName);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return snglXmlHolder.XmlDocument;&nbsp; &nbsp; }.....}[/code]What do you think ?Ojo</blockquote>

[QUOTE="ojo, post: 3180, member: 10402"] I did some profiling using the newly released version of NProf (0.0.9) check [url]http://nprof.sourceforge.net[/url] (they seem to have some problems updating the sourceforge pages, so you will have to check this page for the newest download [url]http://sourceforge.net/project/showfiles.php?group_id=74129[/url]) I found out that in the "main thread" 28% of the processing were done inside AMS.Profile.GetXmlDocument. 59 times the method was called and everytime the document was re-read, reparsed by the System.XML validator and populated into a XmlDocument object. So i did some thinking. Why not read it once and just "cache" it. I realize this is not the final solution, since you will have to make even further changes to make sure the save method works correctly and maybe implement a FileWatcher to get it right. But it is "prove of concept" for the Singleton idear. I made an new Class called SingletonXmlHolder. This class ensures that it only initializes once and reads the XML document once. Then I changed a bit in the GetXmlDocument() method and the result (drumrolls......) 0,15% of the processing time. [code] namespace AMS.Profile { class SingletonXmlHolder { private static SingletonXmlHolder instance; private static System.Xml.XmlDocument _XmlDocument = new System.Xml.XmlDocument(); private SingletonXmlHolder() { } public static SingletonXmlHolder GetInstance(string m_strFileName) { if(instance == null) { instance = new SingletonXmlHolder(); _XmlDocument.Load(m_strFileName); } return instance; } public System.Xml.XmlDocument XmlDocument { get { return _XmlDocument; } } } public class Xml :IDisposable { // Fields private string m_rootName = "profile"; ..... private XmlDocument GetXmlDocument() { // Check kept for the moment but should be moved to SingletonXmlHolder if (!File.Exists(m_strFileName)) return null; SingletonXmlHolder snglXmlHolder = SingletonXmlHolder.GetInstance(m_strFileName); return snglXmlHolder.XmlDocument; } ..... } [/code] What do you think ? Ojo [/QUOTE]

Verification