[Approved] - Heading for virtual keyboard

Hi glenn 1990,

I'm not clear on what the use for heading is especially given that the virtual keyboard has a label property that allows the keyboard user to set a label (or heading, I suppose). In other words you can launch the virtual keyboard as follows. The label is used to prompt the user for what they should enter.

Code (text):

    private static bool GetUserInputString(ref string sString, string label)
    {
      IStandardKeyboard keyboard = (IStandardKeyboard)GUIWindowManager.GetWindow((int)GUIWindow.Window.WINDOW_VIRTUAL_KEYBOARD);
      if (null == keyboard)
      {
        return false;
      }
      keyboard.IsSearchKeyboard = true;
      keyboard.Reset();
      keyboard.Text = sString;
      keyboard.Label = label;
      keyboard.DoModal(GUIWindowManager.ActiveWindowEx);
      if (keyboard.IsConfirmed)
      {
        sString = keyboard.Text;
      }
      return keyboard.IsConfirmed;
    }

Please clarify the use for heading or confirm that the present implementation meets the intended needs.

I'm setting this change as Rejected. If there is a need to revisit then we'll consider with further clarification.

Thanks!

The label/heading can be set by the plugin, so the suggested change is imho not needed. One thing I noticed though;
It looks like inputTextColor is used as color for the label/heading, even though this has its own color called "labelColor".

The stdKeyboard.xml file has this:

Code (text):

    <control>
      <description>standard keyboard</description>
      <type>standardKeyboard</type>
      <id>1</id>
      <keyboardPosX>400</keyboardPosX>
      <keyboardPosY>250</keyboardPosY>
      <keyWidth>44</keyWidth>
      <keyHeight>44</keyHeight>
      <keyHSpacing>0</keyHSpacing>
      <keyVSpacing>2</keyVSpacing>
      <modeKeySpacing>4</modeKeySpacing>
      <modeKeyWidth>110</modeKeyWidth>
      <searchModeKeyWidth>130</searchModeKeyWidth>
      <label></label>
      <labelAlign>center</labelAlign>
      <labelOffX>0</labelOffX>
      <labelOffY>2</labelOffY>
      <labelFont>font10</labelFont>
      <labelColor>FFFFFFFF</labelColor>
      <labelShadowAngle>0</labelShadowAngle>
      <labelShadowDistance>0</labelShadowDistance>
      <labelShadowColor>FF000000</labelShadowColor>
      <labelBoxPosX>0</labelBoxPosX>
      <labelBoxPosY>0</labelBoxPosY>
      <labelBoxWidth>200</labelBoxWidth>
      <labelBoxHeight>30</labelBoxHeight>
      <labelBoxTexture>-</labelBoxTexture>
      <showLabelAsInitialText>no</showLabelAsInitialText>
      <inputTextBoxPosX>403</inputTextBoxPosX>
      <inputTextBoxPosY>213</inputTextBoxPosY>
      <inputTextBoxWidth>-1</inputTextBoxWidth>
      <inputTextBoxHeight>35</inputTextBoxHeight>
      <inputTextAlign>left</inputTextAlign>
      <inputTextOffX>18</inputTextOffX>
      <inputTextOffY>2</inputTextOffY>
      <inputTextFont>font11</inputTextFont>
      <inputTextBoxTexture>keyboard.png</inputTextBoxTexture>
      <inputTextColor>FF000000</inputTextColor>
      <inputTextShadowAngle>0</inputTextShadowAngle>
      <inputTextShadowDistance>0</inputTextShadowDistance>
      <inputTextShadowColor>FF000000</inputTextShadowColor>
      <charKeyFont>font11</charKeyFont>
      <namedKeyFont>font10</namedKeyFont>
      <keyTextShadowAngle>0</keyTextShadowAngle>
      <keyTextShadowDistance>0</keyTextShadowDistance>
      <keyTextShadowColor>FF000000</keyTextShadowColor>
      <keyTextureFocus>key.png</keyTextureFocus>
      <keyTextureNoFocus>keyNF.png</keyTextureNoFocus>
      <keyHighlightColor>ffffffff</keyHighlightColor>
      <keyPressedColor>ff808080</keyPressedColor>
      <keyDisabledColor>FFFFFFFF</keyDisabledColor>
      <keyFontColor>FFffffff</keyFontColor>
      <keySelFontColor>FFffffff</keySelFontColor>
      <keyDisabledFontColor>FF808080</keyDisabledFontColor>
    </control>

Note how labelColor is set to white (FFFFFFFF). Yet still, the label is not rendered white, but black. If you edit inputTextColor and change this to white, then the label suddenly also turns white. Same goes for other colors

So; we have a bug