[Approved] - How to Video database section and My Movies get to life | Page 14

AW: How to Video database section and My Movies get to life

This is no bug but a change in the skin engine for 1.2.0. All skins have to be fixed for that. There is a discussion going on with Mr. Hipp already.

Don't worry, nothing is changed in skin or in functionality in My Videos, it's still the same My Videos but it's working now with some extra little goodies, some new options which was asked long time ago and more usable then ever.

The only said thing that only IMDB with AKA script is 100% functional for it (just pay attention that there are two of them, compatible with current 1.1.1 and older MP:
http://forum.team-mediaportal.com/submit-movie-info-grabbers-287/imdb-not-grabbing-87688/#post666421

and new one which works only from 1.2.0 and after - on first page of this thread).

I will try to see if I can other language IMDB scripts reworked but don't take that as it will be done in a few days.

** Just to add, MP imdb_de_ofdb script still works as nothing changed on German IMDB layout yet so no need to worry for now

Can you tell me what changes are needed for grabbers? I'm the autor of the mymovies.it script and will try to fix it if necessary.

I've tested the script in the afternoon with last SVN and seems to work fine.

Problems is only with scrappers which uses IMDB because they change they web layout recently. Anything else will work as before. Only new thing in 1.2.0 and above is new property "movieDetails.UserReview" which 1.1.1 script and below can't process and will crash if used (thats why is two IMDB aka script).

So, you don't need to worry, everything will work as before.

There seems to be some copy-paste code in this patch that could easily use some method extraction (I guess there is some duplicate code).

While merging the performance improvements patch with the main trunk Inker and I realized this problem.

/gibman

Hi cyberfix, I will look at the code but to calm you down, database was not changed (I just added some new fields in two tables (movieinfo->user review and fanarturl, actorinfo->actor thumb url and IMDB actor id, so if you don't need them everything will work as before). Only potential problem can be new movie thumb filename (I added database ID into filename to prevent overwrite of the thumbs for movies with the same title, before MovieL.jpg->Movie{dbID}L.jpg <curly brackets are part of the filename>) and the only bad thing can happen that you will not see them in My Movies.

Concerning your code, if new tab and it's code part was in separate methods there shouldn't be not any problem, but if you used some of the methods inside MovieDatabase.cs maybe you will need to adapt it but much rework was new added code, old one is not changed too much except in covers handling and some small fixes.

It will be good if you can post your changes as unified diff patch file (against 1.1.1 or better for latets SVN) so I can let you know pretty fast where you can have a problem (if any).

Yes there is some duplicate code, maybe some of them are mine. I already extracted some methods (not committed for now) but there is a still lot of work in code cleaning and optimization. Most of changes I've done is in Moviedatabase.cs (used only in Configuration)and IMDBFetcher.cs (GUI and Config), other files are less touched.

I will do the best I can, also if you can point me out where can be potential improvement I will clean it up immediately.